User tests: Successful: Unsuccessful:
As it is a group of checkboxes then it should be a fieldset and have a legend instead of a label
I could only find one use of checkboxes and that is in the codemirror plugin at the bottom
@zwiastunsw please check this - its based on https://www.w3.org/WAI/tutorials/forms/grouping/
Status | New | ⇒ | Pending |
Category | ⇒ | Layout Front End Plugins |
Labels |
Added:
?
|
cc @zwiastunsw because @brianteeman mistyped Stefan nickname.
The code is correct. Unfortunately, the NVDA does not announce a legend.
I can't explain why.
I extracted the code and put it in a separate HTML document. In this case NVDA announces the legend.
PS It also requires improvement of the CSS, but not in this PR
lol - I did exactly the same. It works perfectly in html but not in this page. weird
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-22 11:06:57 |
Closed_By | ⇒ | wilsonge |
OK If the HTML is fine in theory - I'll merge as this is so that the library is correctly patched and we can do a follow up PR to address the specific usage instance in core
Thanks
As far as I can tell the drone errors are completely unrelated to this PR