? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Feb 2019

As it is a group of checkboxes then it should be a fieldset and have a legend instead of a label

I could only find one use of checkboxes and that is in the codemirror plugin at the bottom

@zwiastunsw please check this - its based on https://www.w3.org/WAI/tutorials/forms/grouping/

avatar brianteeman brianteeman - open - 21 Feb 2019
avatar brianteeman brianteeman - change - 21 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2019
Category Layout Front End Plugins
avatar brianteeman brianteeman - change - 21 Feb 2019
The description was changed
avatar brianteeman brianteeman - edited - 21 Feb 2019
avatar brianteeman
brianteeman - comment - 21 Feb 2019

As far as I can tell the drone errors are completely unrelated to this PR

avatar brianteeman brianteeman - change - 21 Feb 2019
Labels Added: ?
avatar wojsmol
wojsmol - comment - 21 Feb 2019

cc @zwiastunsw because @brianteeman mistyped Stefan nickname.

avatar brianteeman brianteeman - change - 21 Feb 2019
The description was changed
avatar brianteeman brianteeman - edited - 21 Feb 2019
avatar brianteeman
brianteeman - comment - 21 Feb 2019

Thanks @wojsmol fixed it now

avatar zwiastunsw
zwiastunsw - comment - 21 Feb 2019

The code is correct. Unfortunately, the NVDA does not announce a legend.
I can't explain why.
I extracted the code and put it in a separate HTML document. In this case NVDA announces the legend.

PS It also requires improvement of the CSS, but not in this PR

avatar brianteeman
brianteeman - comment - 21 Feb 2019

lol - I did exactly the same. It works perfectly in html but not in this page. weird

avatar wilsonge wilsonge - close - 22 Feb 2019
avatar wilsonge wilsonge - merge - 22 Feb 2019
avatar wilsonge wilsonge - change - 22 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-22 11:06:57
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 22 Feb 2019

OK If the HTML is fine in theory - I'll merge as this is so that the library is correctly patched and we can do a follow up PR to address the specific usage instance in core

avatar brianteeman
brianteeman - comment - 22 Feb 2019

Thanks

Add a Comment

Login with GitHub to post a comment