? ? ? Pending

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
21 Feb 2019

Signed-off-by: Nitish Bahl nitishbahl24@gmail.com

Pull Request for Issue - Download string is used in many .vue files, but translation missing in lang files(media manager) .
I am not sure if this is duplicate or not, kindly check

avatar bahl24 bahl24 - open - 21 Feb 2019
avatar bahl24 bahl24 - change - 21 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2019
Category Administration com_media Language & Strings
avatar bahl24 bahl24 - change - 21 Feb 2019
The description was changed
avatar bahl24 bahl24 - edited - 21 Feb 2019
avatar bahl24 bahl24 - change - 21 Feb 2019
Labels Added: ? ?
avatar bahl24
bahl24 - comment - 22 Feb 2019

@infograf768 Can you test this?

avatar infograf768
infograf768 - comment - 22 Feb 2019

I have tested this item successfully on 24b3611


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23967.

avatar infograf768
infograf768 - comment - 22 Feb 2019

I have tested this item successfully on 24b3611


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23967.

avatar infograf768 infograf768 - test_item - 22 Feb 2019 - Tested successfully
avatar infograf768 infograf768 - change - 22 Feb 2019
Title
[4.0]initialized download string
[4.0]com_media missing download lang string
avatar infograf768 infograf768 - edited - 22 Feb 2019
avatar bahl24
bahl24 - comment - 26 Feb 2019

@Quy @HLeithner Kindly review

avatar bahl24
bahl24 - comment - 26 Feb 2019

@Quy I have modified it, kindly test

avatar Quy Quy - test_item - 26 Feb 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Feb 2019

I have tested this item successfully on a5188f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23967.

avatar bahl24
bahl24 - comment - 2 Mar 2019

@Quy RTC?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Mar 2019

@bahl24 can you please merge the latest changes from 4.0-dev?

@infograf768 @Quy can you please retest?

avatar bahl24
bahl24 - comment - 3 Mar 2019

Is there any problem?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Mar 2019

screen shot 2019-03-03 at 10 18 06

avatar infograf768
infograf768 - comment - 3 Mar 2019

There are some problems with drone. Should be solved soon.

avatar brianteeman
brianteeman - comment - 3 Mar 2019

@franz-wohlkoenig a branch being out of date is not a problem - unless there are merge conflicts

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Mar 2019

@brianteeman thanks for remembering me.

avatar bahl24
bahl24 - comment - 3 Mar 2019

Kindly test this

avatar Quy
Quy - comment - 4 Mar 2019

@infograf768 Are you ok with the language change?

avatar infograf768
infograf768 - comment - 4 Mar 2019

@infograf768 Are you ok with the language change?

yep

avatar Quy Quy - change - 4 Mar 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Mar 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23967.

avatar infograf768 infograf768 - change - 4 Mar 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 7 Mar 2019

As this would conflict with
#23951
It is better to first correct that one and then merge this one.

avatar infograf768 infograf768 - change - 7 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-07 14:16:34
Closed_By infograf768
avatar infograf768 infograf768 - close - 7 Mar 2019
avatar infograf768 infograf768 - merge - 7 Mar 2019
avatar infograf768
infograf768 - comment - 7 Mar 2019

thanks

Add a Comment

Login with GitHub to post a comment