Joomla! Issue Tracker | Joomla! CMS #23954 - Invalid comments in modules?

Closed
21 Feb 2019
Medium
Build: staging
# 23954

brianteeman
20 Feb 2019

Am I being daft and missing something but when I read

joomla-cms/modules/mod_articles_latest/helper.php

Lines 47 to 50 in a66130a

    
           		// Set the filters based on the module params 
        
           		$model->setState('list.start', 0); 
        
           		$model->setState('list.limit', (int) $params->get('count', 5)); 
        
           		$model->setState('filter.published', 1);

The comment implies to me that each of these is set by a param in the module. But only one of those is actually set by a param in the module

brianteeman - open - 20 Feb 2019

joomla-cms-bot - change - 20 Feb 2019

Labels

Added: ?

joomla-cms-bot - labeled - 20 Feb 2019

HLeithner - comment - 20 Feb 2019

I think you only need the count parameter, because you want the latest X articles that are visible.

But yes I think you can remove the comment if you want.

brianteeman - comment - 20 Feb 2019

Annoyingly I actually wanted to be able to display unpublished items which is how I came to this code

brianteeman - comment - 21 Feb 2019

Closed see #23964 for solution

brianteeman - close - 21 Feb 2019

brianteeman - change - 21 Feb 2019

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2019-02-21 09:59:12
Closed_By		⇒	brianteeman

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#23954] - Invalid comments in modules?

Add a Comment

	// Set the filters based on the module params
	$model->setState('list.start', 0);
	$model->setState('list.limit', (int) $params->get('count', 5));
	$model->setState('filter.published', 1);