[#23951] - [4.0]Added lang string for upload file
- Fixed in Code Base
- 7 Mar 2019
- Medium
- Build: 4.0-dev
- # 23951
- Diff
- bahl24:lang_string
User tests: Successful: Unsuccessful:
Signed-off-by: Nitish Bahl nitishbahl24@gmail.com
Pull Request for Issue #23947 .
Summary of Changes
Added lang string for translation in media manager
Testing Instructions
Expected result
Lang file added for translation purposes
Actual result
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Language & Strings |
You also have to add the string in
/administrator/components/com_media/tmpl/media/default_texts.php
Text::script('COM_MEDIA_DROP_FILE', true);
| Labels |
Added:
?
NPM Resource Changed
?
|
||
@infograf768 I have added that
Thanks, it will work now.
It is better to always test your patches on a local site.
NOTE: we will have to alpha order these in another PR as anyway we have to modify/add some new strings in that file.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23951.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23951.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23951.
| Labels |
Added:
?
|
||
Please resolve conflicts. I modified the default_texts.php and this was merged. Therefore the string should be added in alphabetic order in that file AND also in both com_media.ini files (front and backend)
@infograf768 I have made the changes.
I added it. waiting for Checks to pass to merge.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-07 10:34:30 |
| Closed_By | ⇒ | infograf768 |
Thanks
I have tested this item✅ successfully on 42004af
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23951.