User tests: Successful: Unsuccessful:
Signed-off-by: Nitish Bahl nitishbahl24@gmail.com
Pull Request for Issue - Intended line break is does not work in checked out articles/categories etc .
Checkout any article or category.
Tested in chrome and firefox.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
@brianteeman What is the issue? <br>
is not rendered in the earlier way.
https://stackoverflow.com/questions/358874/how-can-i-use-a-carriage-return-in-a-html-tooltip
strong has meaning and you have removed that meaning
@brianteeman I apologize for it, but I have tried using <strong>
,<b>
enclosed in both ''
& ""
but could not find a way to make it strong. Any suggestions?
@C-Lodder @bembelimen @chmst
Tooltips SHOULD NOT have any markup in the text, deal with it...
@dgrammatiko @infograf768 I agree and there is no way to have markup in tooltip, that's why I chose to ignore the strong tag given. Nor have I ever seen something in which tooltip is formatted. Deleting strong tag looks like the only solution having no effect on functionality.
@bahl24 I guess you haven't looked hard as it is very common - just because you don't know how to do something is no reason to arbitrarily remove it. And just because @dgrammatiko doesn't believe a tooltip should have markup doesnt mean he is correct either - thats just an arbirtary opinion
thats just an arbirtary opinion
No, my case was about XSS. Whenever you want to pass a tag in the js then you have to either:
Anyways the element.innerHTML is really bad for XSS, Joomla is using it all over the place because of ignorance, check the latest version there is a hint there.
All and all I'm standing in my opinion that innerHTML is not safe and shouldn't be use and tooltips with rich text are based on that. Of course, is Joomla's decision if they will keep delivering unsafe scripts or they'll drop or find other ways to implement that...
To put it simple: aria-labelledby
accepts rich HTML?
No!
It's the same reason, you cannot parse safely rich HTML thus the platform (not some random guy like me) doesn't allow it...
use a proper way to build the tooltip in the js.
Why not do that - thats how it is normally done
Why not do that - thats how it is normally done
Its far easier to drop the span, br, etc than doing anything else
That's a pathetic lazy reason
I could return the pathetic to the idea that tooltips must have rich HTML
Title |
|
Brian's correct we should have semantic html in the tooltips. This isn't the correct fix.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-14 10:39:22 |
Closed_By | ⇒ | wilsonge | |
Labels |
Removed:
J4 Issue
|
This is not correct