? Success

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
19 Feb 2019

Signed-off-by: Nitish Bahl nitishbahl24@gmail.com

Pull Request for Issue - Intended line break is does not work in checked out articles/categories etc .

Testing Instructions

Checkout any article or category.
Tested in chrome and firefox.

Expected result

capture19-2

Actual result

capturewr

Documentation Changes Required- No

avatar bahl24 bahl24 - open - 19 Feb 2019
avatar bahl24 bahl24 - change - 19 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2019
Category Libraries
avatar bahl24 bahl24 - change - 19 Feb 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 19 Feb 2019

This is not correct

avatar bahl24
bahl24 - comment - 19 Feb 2019
avatar brianteeman
brianteeman - comment - 19 Feb 2019

strong has meaning and you have removed that meaning

avatar bahl24
bahl24 - comment - 19 Feb 2019

@brianteeman I apologize for it, but I have tried using <strong>,<b> enclosed in both '' & "" but could not find a way to make it strong. Any suggestions?
@C-Lodder @bembelimen @chmst

avatar dgrammatiko
dgrammatiko - comment - 19 Feb 2019

Tooltips SHOULD NOT have any markup in the text, deal with it...

avatar bahl24
bahl24 - comment - 19 Feb 2019

@dgrammatiko @infograf768 I agree and there is no way to have markup in tooltip, that's why I chose to ignore the strong tag given. Nor have I ever seen something in which tooltip is formatted. Deleting strong tag looks like the only solution having no effect on functionality.

avatar brianteeman
brianteeman - comment - 19 Feb 2019

@bahl24 I guess you haven't looked hard as it is very common - just because you don't know how to do something is no reason to arbitrarily remove it. And just because @dgrammatiko doesn't believe a tooltip should have markup doesnt mean he is correct either - thats just an arbirtary opinion

avatar dgrammatiko
dgrammatiko - comment - 19 Feb 2019

thats just an arbirtary opinion

No, my case was about XSS. Whenever you want to pass a tag in the js then you have to either:

  • use innerHTML, it's not safe and you shouldn't
  • use a proper way to build the tooltip in the js.

Anyways the element.innerHTML is really bad for XSS, Joomla is using it all over the place because of ignorance, check the latest version there is a hint there.
All and all I'm standing in my opinion that innerHTML is not safe and shouldn't be use and tooltips with rich text are based on that. Of course, is Joomla's decision if they will keep delivering unsafe scripts or they'll drop or find other ways to implement that...

avatar dgrammatiko
dgrammatiko - comment - 19 Feb 2019

To put it simple: aria-labelledby accepts rich HTML?
No!
It's the same reason, you cannot parse safely rich HTML thus the platform (not some random guy like me) doesn't allow it...

avatar brianteeman
brianteeman - comment - 19 Feb 2019

use a proper way to build the tooltip in the js.
Why not do that - thats how it is normally done

avatar dgrammatiko
dgrammatiko - comment - 19 Feb 2019

Why not do that - thats how it is normally done

Its far easier to drop the span, br, etc than doing anything else

avatar brianteeman
brianteeman - comment - 19 Feb 2019

That's a pathetic lazy reason

avatar dgrammatiko
dgrammatiko - comment - 19 Feb 2019

I could return the pathetic to the idea that tooltips must have rich HTML

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[4.0]Line Break missing in checked out articles/category
[4.0] Line Break missing in checked out articles/category
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar wilsonge
wilsonge - comment - 14 May 2019

Brian's correct we should have semantic html in the tooltips. This isn't the correct fix.

avatar wilsonge wilsonge - change - 14 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-14 10:39:22
Closed_By wilsonge
Labels Removed: J4 Issue
avatar wilsonge wilsonge - close - 14 May 2019

Add a Comment

Login with GitHub to post a comment