? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
19 Feb 2019

…group

Pull Request for Issue #21989

Summary of Changes

All edit views were changed to separate Save (and stay) button from Save button group

Testing Instructions

Expected result

A "Save" button and a "Save & Close" / "Save & New" button group

Actual result

Save is integrated in the grouped button

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 19 Feb 2019
avatar drmenzelit drmenzelit - change - 19 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2019
Category Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_languages com_menus com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users com_workflow
avatar chmst
chmst - comment - 19 Feb 2019

I have tested this item successfully on 0ca1857


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23942.

avatar chmst chmst - test_item - 19 Feb 2019 - Tested successfully
avatar drmenzelit drmenzelit - change - 19 Feb 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 19 Feb 2019

In the design document and #21989 the same icon is used for the save button and the save as grouped button. In this pr there are two different icons

avatar coolcat-creations
coolcat-creations - comment - 19 Feb 2019

I would recommend to merge this (After tests) and take the Icons for the discussion of a second PR. Then we could maybe discuss also if we use the wording „apply“ instead of save. But for now this PR solves a big UX issue and would be great to have.

avatar PhocaCz
PhocaCz - comment - 19 Feb 2019

I have tested this item successfully on 0a6fbd5

Tested on:
Joomla! 4.0.0-alpha7-dev successfully

Tags


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23942.

avatar PhocaCz PhocaCz - test_item - 19 Feb 2019 - Tested successfully
avatar HLeithner HLeithner - change - 21 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-21 12:32:55
Closed_By HLeithner
avatar HLeithner HLeithner - close - 21 Feb 2019
avatar HLeithner HLeithner - merge - 21 Feb 2019
avatar HLeithner
HLeithner - comment - 21 Feb 2019

thx

avatar puneet0191
puneet0191 - comment - 21 Feb 2019

@HLeithner seems to work now, please merge this asap so we can have other PR's also green

avatar HLeithner
HLeithner - comment - 21 Feb 2019

@puneet0191 you have to write faster ;-)

avatar puneet0191
puneet0191 - comment - 21 Feb 2019

and also less, I wrote too many words ?

Add a Comment

Login with GitHub to post a comment