Feeling Lucky
?
[#23929] - [4.0] switcher lables color changed
- Closed
- 18 Feb 2019
- Medium
- Build: 4.0-dev
- # 23929
- Diff
- puneeth2001:switcher_lables
User tests: Successful: Unsuccessful:
Pull Request for Issue #23863
Summary of Changes
Changed the color of field switcher labels.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
C-Lodder
- comment
- 18 Feb 2019
We don't use black font colours by default incase they're ever mixed with a white background which poses an a11y issue. Please use var(--dark) instead.
Please also add [4.0] to the title so everyone knows it's for Joomla 4
| Labels |
Added:
?
|
||
C-Lodder
- comment
- 18 Feb 2019
@puneeth2001 still incorrect. Replace color: var(--dark, $gray-600); with color: var(--dark);
You also have a merge conflict which needs fixing.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-18 08:59:47 |
| Closed_By | ⇒ | puneeth2001 |
wilsonge
- comment
- 18 Apr 2019
I think so
@puneeth2001 Please resolve merge conflict.