Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23923] - [4.0] Fix params in method preprocessForm from model menuItems

? Failure

User tests: Successful: Unsuccessful:

avatar chmst
chmst
17 Feb 2019

Summary of Changes

Method preprocessForm() in model menu/ItemsModel throws a warning.

preprocessForm(JForm $form, $data, $group = 'content') should be compatible with Joomla\CMS\MVC\Model\ListModel::preprocessForm(Joomla\CMS\Form\Form $form, $data, $group = 'content') in administrator\components\com_menus\Model\ItemsModel.php on line 600

Testing Instructions

Inspect code.

avatar chmst chmst - open - 17 Feb 2019
avatar chmst chmst - change - 17 Feb 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2019
Category ⇒ Administration com_menus
avatar chmst chmst - change - 17 Feb 2019
Title
…
Remove unused method preprocessForm from model menuItems
[4.0] Remove unused method preprocessForm from model menuItems
avatar chmst chmst - edited - 17 Feb 2019
avatar SharkyKZ
SharkyKZ - comment - 17 Feb 2019

It is used.

avatar chmst
chmst - comment - 17 Feb 2019

@SharkyKZ - thank you, can you say me where? I could not find a usage - as in general preprocessForm ist not used in ListModels.

avatar SharkyKZ
SharkyKZ - comment - 17 Feb 2019

It alters the filter form in list view.

avatar chmst chmst - change - 17 Feb 2019
Labels Added: ?
avatar chmst chmst - change - 17 Feb 2019
Title
…
[4.0] Remove unused method preprocessForm from model menuItems
[4.0] Fix params in method preprocessForm from model menuItems
avatar chmst chmst - edited - 17 Feb 2019
avatar chmst chmst - change - 17 Feb 2019
The description was changed
avatar chmst chmst - edited - 17 Feb 2019
avatar chmst
chmst - comment - 17 Feb 2019

Thank you, @SharkyKZ you are right. I got a Warning for the method when using the model in another module. Removing the method helped in the module but was definitely too much. ;) Now this works better

avatar chmst chmst - change - 19 Feb 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-02-19 08:34:12
Closed_By ⇒ chmst
avatar chmst chmst - close - 19 Feb 2019

Add a Comment

Login with GitHub to post a comment