J3 Issue ? Failure

User tests: Successful: Unsuccessful:

avatar puneeth2001
puneeth2001
14 Feb 2019

Pull Request for Issue #23636

Summary of Changes

The backdrop which is getting overlapped is deleted so that it has a workable UI.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar puneeth2001 puneeth2001 - open - 14 Feb 2019
avatar puneeth2001 puneeth2001 - change - 14 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2019
Category Layout
avatar brianteeman
brianteeman - comment - 14 Feb 2019

As @C-Lodder says we need the backdrop

avatar dgrammatiko
dgrammatiko - comment - 14 Feb 2019

@puneeth2001 I'm afraid this is not an acceptable solution

avatar ciar4n
ciar4n - comment - 14 Feb 2019

@dgrammatiko Is it possible to echo the modal before the closing body tag? I believe this is the only real solution here.

avatar dgrammatiko
dgrammatiko - comment - 14 Feb 2019

@dgrammatiko but I did that already: #21852
and the dinos said no. Go figure...

avatar ciar4n
ciar4n - comment - 14 Feb 2019
avatar ciar4n
ciar4n - comment - 14 Feb 2019

Common sense failing, there is only 2 other possible options that I see. Neither of which are ideal.

  1. Echo the backdrop with the modal and set z-index: -1; on the backdrop.
  2. Have the body tag the only relative element on the tree to the modal (remove position:sticky on the .subhead)
avatar dgrammatiko
dgrammatiko - comment - 14 Feb 2019

@ciar4n as far as I remember the goal was to move all the server side rendered modals before the closing body tag. Also, this was a decision because we want to move to <dialog> which at some part will require 0 js on all browsers. People against this were talking about losing the ability to style those and that's totally stupid because you can pass any unique class to each modal, thus that reason was completely boll**ks...
People are trying hard to resist any needed changes...

avatar ciar4n
ciar4n - comment - 14 Feb 2019

Your pr really needs to be reconsidered.

avatar brianteeman
brianteeman - comment - 14 Feb 2019

yes please to just dropping modals and moving to dialog - semantically they are more correct and they are much more accessible

avatar ReLater
ReLater - comment - 15 Feb 2019

As @C-Lodder says we need the backdrop

And why do we need backdrops? Any comprehensible reasons?

avatar C-Lodder
C-Lodder - comment - 15 Feb 2019

@ReLater check my comment on the issue.

It's UX related.

avatar C-Lodder
C-Lodder - comment - 15 Feb 2019

Im all for dialogs. Shame more browsers dont support them yet but polyfills can be used.

If we keep the modals for now, then the markup needs to be injected before the closing body tag. All these z-index fixes will eventually cause problems in the future

avatar bembelimen
bembelimen - comment - 15 Feb 2019

@dgrammatiko but I did that already: #21852
and the dinos said no. Go figure...

Not sure, were you saw someone against it...If you mean my comment, I just wrote something which should be considered, nothing more.
This PR is definitely not the solution, yours would have been, if you wouldn't be offended by nothing and would have improved instead of closing it.

avatar brianteeman
brianteeman - comment - 15 Feb 2019

This works great and works for all supported browsers http://edenspiekermann.github.io/a11y-dialog/example/

avatar bembelimen
bembelimen - comment - 15 Feb 2019

This works great and works for all supported browsers http://edenspiekermann.github.io/a11y-dialog/example/

Look good, but the backdrop problem will be there, too? So we need two changes: implement the new script + fix the backdrop.

avatar ciar4n
ciar4n - comment - 15 Feb 2019

This works great and works for all supported browsers http://edenspiekermann.github.io/a11y-dialog/example/

This example injects the backdrop with the modal which should resolve the backdrop issue.

avatar brianteeman
brianteeman - comment - 15 Feb 2019

@ciar4n exactly right - and its much more accessible etc etc

avatar Quy Quy - change - 4 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-04 14:37:49
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2019
Closed_Date 2019-05-04 14:37:49 2019-05-04 14:37:50
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 4 May 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 May 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23906

avatar Quy
Quy - comment - 4 May 2019

Closing for reasons stated. Maybe PR #24369 is a possible solution.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23906.

avatar Quy
Quy - comment - 4 May 2019

Closing for reasons stated. Maybe PR #24369 is a possible solution.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23906.

avatar infograf768
infograf768 - comment - 9 Jun 2019

Please look at #25147

Add a Comment

Login with GitHub to post a comment