User tests: Successful: Unsuccessful:
Pull Request for Issue #23636
The backdrop which is getting overlapped is deleted so that it has a workable UI.
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
@puneeth2001 I'm afraid this is not an acceptable solution
@dgrammatiko Is it possible to echo the modal before the closing body tag? I believe this is the only real solution here.
@dgrammatiko but I did that already: #21852
and the dinos said no. Go figure...
Common sense failing, there is only 2 other possible options that I see. Neither of which are ideal.
z-index: -1;
on the backdrop.position:sticky
on the .subhead
)@ciar4n as far as I remember the goal was to move all the server side rendered modals before the closing body tag. Also, this was a decision because we want to move to <dialog>
which at some part will require 0 js on all browsers. People against this were talking about losing the ability to style those and that's totally stupid because you can pass any unique class to each modal, thus that reason was completely boll**ks...
People are trying hard to resist any needed changes...
Your pr really needs to be reconsidered.
yes please to just dropping modals and moving to dialog - semantically they are more correct and they are much more accessible
Im all for dialogs. Shame more browsers dont support them yet but polyfills can be used.
If we keep the modals for now, then the markup needs to be injected before the closing body tag. All these z-index fixes will eventually cause problems in the future
@dgrammatiko but I did that already: #21852
and the dinos said no. Go figure...
Not sure, were you saw someone against it...If you mean my comment, I just wrote something which should be considered, nothing more.
This PR is definitely not the solution, yours would have been, if you wouldn't be offended by nothing and would have improved instead of closing it.
This works great and works for all supported browsers http://edenspiekermann.github.io/a11y-dialog/example/
This works great and works for all supported browsers http://edenspiekermann.github.io/a11y-dialog/example/
Look good, but the backdrop problem will be there, too? So we need two changes: implement the new script + fix the backdrop.
This works great and works for all supported browsers http://edenspiekermann.github.io/a11y-dialog/example/
This example injects the backdrop with the modal which should resolve the backdrop issue.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 14:37:49 |
Closed_By | ⇒ | Quy |
Closed_Date | 2019-05-04 14:37:49 | ⇒ | 2019-05-04 14:37:50 |
Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23906
Closing for reasons stated. Maybe PR #24369 is a possible solution.
Closing for reasons stated. Maybe PR #24369 is a possible solution.
As @C-Lodder says we need the backdrop