[#23878] - [4.0]fixed language of 'insert image' to 'Insert Image'
- Fixed in Code Base
- 13 Feb 2019
- Medium
- Build: 4.0-dev
- # 23878
- Diff
- bahl24:fix#23832
User tests: Successful: Unsuccessful:
Signed-off-by: Nitish Bahl nitishbahl24@gmail.com
Pull Request for Issue - 'insert image' should have capital first char
- New article->cms content
Expected result
Actual result
Should I add a language def which might help in translation in future
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
The comment behind it is actually the important part. That string should be translatable. So it should go through
Text::_()and the string being defined in a language file.
Ok, that's what I meant to say by asking if we need a lang def.
@Bakual Done, kindly see if the string name is according to convention or needs to be modified
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
Done, kindly see if the string name is according to convention or needs to be modified
The name is fine, just change what Brian was already pointing out then this PR is perfect. Thanks already!
| Labels |
Added:
?
|
||
@brianteeman @Bakual @infograf768 Changes have been incorporated. Kindly test this
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23878.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23878.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23878.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23878.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-13 11:15:08 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
|
||
Merged, thanks for the contribution!
The comment behind it is actually the important part. That string should be translatable. So it should go through
Text::_()and the string being defined in a language file.