? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
10 Feb 2019

Closes #23338

Summary of Changes

GPL Compliant change to FOF Dispatcher for PHP 7.3 Compatibility

s/continue/continue 2/

Testing Instructions

Run PHP 7.3.2
Access Post Install Messages or anything that invokes the old fof dispatcher

Expected result

No warnings

Actual result

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 524

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 529

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 534

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 539

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 552

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 561

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 566

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 580

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 609

Documentation Changes Required

None

Note

The GPL required change to the file header is non-negotiable, if you dont like my wording, write your own and PR that. I shall not be going back and forth changing it. I have not specified the exact date of the change as that will be when the PR is merged, and that can be from hours, to years from now. It is not required for me personally to be named in the GPL required statement

  • - "You must cause the modified files to carry" - Done.
  • - "modified files to carry prominent notices" - Done.
  • - "stating that you changed the files" (assuming you can mean "The Joomla Project")
  • - "the date of any change" (early 2019 is good enough).

@nikosdion

avatar PhilETaylor PhilETaylor - open - 10 Feb 2019
avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2019
Category External Library Libraries
avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
The description was changed
avatar PhilETaylor PhilETaylor - edited - 10 Feb 2019
avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
The description was changed
avatar PhilETaylor PhilETaylor - edited - 10 Feb 2019
avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:35:50
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment