[#23862] - [4.0] [a11y] Adding Label for Login Module password field
- Closed
- 11 Feb 2019
- Medium
- Build: 4.0-dev
- # 23862
- Diff
- infograf768:4.0_password_accessibility
User tests: Successful: Unsuccessful:
Pull Request for Issue #23860
Summary of Changes
Label added
Testing Instructions
See source code for the frontend login module
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
@infograf768 can you do your PR against: #23215
The current HTML is not the actual output of the field that we want, as the field needs to be a Custom Element
Actually this is already done in that PR
@dgrammatiko
I can close this PR indeed. I have tested your PR and I see that label is added but the class class="sr-only" is absent. Is that OK? @zwiastunsw
@infograf768 there is no class sr-only but there is a non Bootstrap class with the same effect: https://github.com/joomla/joomla-cms/pull/23215/files#diff-b38b2a09fa4b4f3eefc4fdc9db3d87e5R154
The reason is that none of the input fields (the custom elements I mean) should be Bootstrap or Font Awesome dependant...
OK, closing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-11 10:36:49 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on d807449
thx
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23862.