[#23858] - PHP 7.3.x Compatibility in FOF Dispatcher
- Closed
- 10 Feb 2019
- Medium
- Build: staging
- # 23858
- Diff
- PhilETaylor:patch-51
User tests: Successful: Unsuccessful:
Closes #23338
Summary of Changes
PHP 7.3.x Compatibility in FOF Dispatcher
s/continue/continue 2/
Testing Instructions
Run PHP 7.3.2
Access Post Install Messages or anything that invokes the old fof dispatcher
Expected result
No warnings
Actual result
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 524
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 529
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 534
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 539
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 552
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 561
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 566
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 580
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/.../libraries/fof/dispatcher/dispatcher.php on line 609
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
None of the other changes made in the /libraries/fof folder have ever updated the copyright when making changes (Except when Nic does them). I'm just following that tradition. Rightly or wrongly.
Eg.
- https://github.com/joomla/joomla-cms/pull/12497/files#diff-8b69062cbcd3f1803786e6cf1ebb2204
- PhilETaylor@e6f73bc#diff-f2a6b547b0ac0c6ffbc9fb6b5ccad53d
You are free to submit your own competing PR should you wish.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-10 14:41:25 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
Kindly note that at no point did we sign shared copyright of FOF with OpenSourceMatters Inc. It was very clear that the OSM Inc and the Joomla! project chose to bundle our copyrighted software (FOF 2) with their software (Joomla!).
FOF 2 is licensed under the GPL 2. Article 2, paragraph "a" of the License stipulates:
a. You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change.
If the Joomla! project has made changes without putting prominent notices it is in violation of the License of the Software. Please add the notices as stipulated by the License to restore compliance with the License.
If the Joomla! project has made changes without putting prominent notices it is in violation of the License of the Software.
Then this is clearly the case and something for the Copyright holder to take up with the project management/oversight.
Ironically, @brianteeman chimed in on the other fof changes, and even modified comments in fof code himself, without demanding changes to those PR's for copyright issues... yet chose to do so on mine.
My PR has been closed and my branch deleted.
Good point. Being one of the copyright holders and a representative of the other one I did send a request to OpenSourceMatters Inc since they're the legal entity behind Joomla!.
Regarding your PR, I don't see why you closed it when you could just add a small note at the top of the file reading something along the lines of "This file was changed on February 10th, 2019 by Phil E. Taylor on behalf of the Joomla! project, replacing continue with continue 2 to effect PHP 7.3 compatibility". That's really all there is to it. Of course it's your PR and your right to close it without giving an excuse, I am just saying the only thing that was missing for me to add a successful test to it...
As @nikosdion stated you need to update the copyright