[#23847] - [4.0] Update joomla/console package and adapt code to changes
- Fixed in Code Base
- 20 Feb 2019
- Medium
- Build: 4.0-dev
- # 23847
- Diff
- mbabker:update-console
User tests: Successful: Unsuccessful:
Summary of Changes
This PR updates the joomla/console package based on the last architectural update and adapts the classes within the CMS environment to those changes. This PR also includes other minor updates to the service definition of the console application class.
Changes include:
- Update application constructor signature to match new structure
- Update all command classes to new structure
- Update console application service to use the defined
session.cliservice versus the inlined session service and to inject via constructor the dispatcher and container dependencies
Testing Instructions
Apply this patch to a local installation and run composer install to pull the updated Composer dependencies. Run php cli/joomla.php <command> to validate console runs, keeping #23845 in mind and if necessary updating your environment.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change Libraries |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-19 01:55:28 |
| Closed_By | ⇒ | mbabker |
Can you please re-open this one. I havn't have time to look into all PRs but it seams i have missed this. Can you give this an seccond chance?
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-02-19 01:55:28 | ⇒ | |
| Closed_By | mbabker | ⇒ |
| Status | New | ⇒ | Pending |
Thanks Michael this is now on my personal to-do list. It might take some time but it will not be forgotten.
I have tested this item
I can confirm that this PR fixed the issue (needed to disable debug plugin as described). Thx michael.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23847.
I have tested this item
I can confirm that this PR fixed the issue (needed to disable debug plugin as described). Thx michael.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23847.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23847.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-20 13:49:19 |
| Closed_By | ⇒ | HLeithner |
thx
Thanks for testing and merging guys
Not quite sure why I spent time on proper CLI support for an application that can't even properly support its non-HTML outputs.