[#23843] - [4.0] Made Non CE tabs responsive
- Closed
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 23843
- Diff
- hardik-codes:Fix#23819
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23819
Summary of Changes
Added flex-wrap: wrap in media queries.
Changing flex-wrap: unset to flex-wrap: wrap in .nav .nav-tabs selector was wrapping the tabs in desktop mode also, to avoid this media queries were added to achieve the effect
Testing Instructions
Go to Content ->Articles -> Options
Expected result
Actual result
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
Considering your tabs are no longer justified, you should probably switch the side of the divider.
to..
box-shadow: 1px 0 0 rgba(0, 0, 0, .1);
Done
@hardik-codes please no! there is already a PR for this
#23780
@dgrammatiko I think the tabs talked about in issues #23819 and #22793 are different.
No they are the same and even if there is another tabs element based on bootstrap the solution is to convert it to the custom element not temporarily fix the code that will be removed
what is CE?
@dgrammatiko shouldn't this be 1280px?
And you forgot a LF :P
@N6REJ @hardik-codes again the aim is to NOT use any of the bootstrap ui components like modals, accordions, tabs, dropdowns, etc.
Your fix here is really useless, the right way is #23780
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23843.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 09:08:58 |
| Closed_By | ⇒ | Quy |
@ciar4n please review the changes