? ? Pending

User tests: Successful: Unsuccessful:

avatar vijay9908
vijay9908
9 Feb 2019

Pull Request for Issue #23630

Summary of Changes

Fixed the untranslated strings and removed the decoupled web-links sourced from media-wiki.

Testing Instructions

Expected result

No untranslated strings in help page of Joomla

Actual result

There are no untranslated strings in help page of Joomla

Documentation Changes Required

avatar vijay9908 vijay9908 - open - 9 Feb 2019
avatar vijay9908 vijay9908 - change - 9 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2019
Category Unit Tests Repository Administration com_admin
avatar C-Lodder
C-Lodder - comment - 9 Feb 2019

Please set the base branch as 4.0-dev

avatar Bakual
Bakual - comment - 9 Feb 2019

This one is against the wrong branch ('staging' instead' of '4-0-dev') and also wants to fix the same issue as your other PR #23837
What do you want to do?

Also please use better titles for your PRs.

avatar vijay9908
vijay9908 - comment - 9 Feb 2019

I issued PR for 4.0-dev as said by C-Lodder.

Will definitely use good titles for PR's from next time.Thankyou.

avatar C-Lodder
C-Lodder - comment - 9 Feb 2019

@vijay9908 - Please close this if you are using a different PR

avatar vijay9908 vijay9908 - change - 9 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-09 11:53:29
Closed_By vijay9908
Labels Added: ? ?
avatar vijay9908 vijay9908 - close - 9 Feb 2019
avatar Bakual
Bakual - comment - 9 Feb 2019

@vijay9908 When you create the PR, you can choose to which branch you want to do it.
It looks like you did your modification based on the 4.0-dev branch, which is fine. But when you create the PR you have to make sure to select the right branch as well.

Base branch and title can also be changed afterwards. JUst click the edit button behind the title.

Add a Comment

Login with GitHub to post a comment