[#23804] - [4.0] Disable Back to Control Panel link
- Fixed in Code Base
- 9 Feb 2019
- Medium
- Build: 4.0-dev
- # 23804
- Diff
- brianteeman:cp-back
User tests: Successful: Unsuccessful:
In Joomla 3.x we disabled the control panel link in the top left hand corner of the admin at the same time that we disabled the main menu. Amongst other reasons this was to prevent people from leaving an item checked out.
In Joomla 4 the link is always active :(
This PR fixes that.
Test
Open an article and ensure that the control panel link in the top left hand corner of the admin does not work
Close the article and ensure that the link works
Related PR
See #23752
Note
The template design team might want to change the icon or styling when it is disabled but that's beyond the scope of this PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
Agree with patch, but let's reinstate the "Show Admin" in a new window in the status module as it is very convenient when testing stuff.
I can make a patch.
<li class="nav-item">
<a class="nav-link" href="<?php echo Route::_('index.php'); ?>" title="<?php echo Text::_('MOD_STATUS_SHOWADMIN'); ?>" target="_blank">
<span class="fa fa-home" aria-hidden="true"></span>
<span class="sr-only"><?php echo Text::_('MOD_STATUS_SHOWADMIN'); ?></span>
</a>
</li>
That is off topic for this PR
That is off topic for this PR
It is totally related as, with this PR, we lose the possibility to switch to admin without touching at the page we are working on.
The point is to discuss the undesired consequences of this PR which, by itself, is fine.
Evidently that would be for a new PR.
Again, instead of commenting on the proposal, I read here only useless feedback.
Will create new PR.
We dont lose anything with this PR. You are talking about an option in j3 that was already removed in j4. If you dont like that the option was removed somewhere else then raise it there or create a new issue.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23804.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23804.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-09 14:02:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on 96d8045
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23804.