J4 Issue ?
avatar C-Lodder
C-Lodder
8 Feb 2019

Steps to reproduce the issue

  1. Go to administrator/index.php?option=com_languages&view=overrides

You'll notice the search box has grey buttons as is on the left hand side, whereas on other pages, it's on the right hand side with blue buttons

Actual result

screeny3

avatar C-Lodder C-Lodder - open - 8 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Feb 2019
avatar hardik-codes
hardik-codes - comment - 8 Feb 2019

@C-Lodder the searchbox is also a little bit different than on other pages as other searchboxes do not have a clear button and the dropdown menu from number of results on the page, unlike this one. I'll be aligning it to the right ad changing the color to blue. Is that okay?

avatar C-Lodder
C-Lodder - comment - 8 Feb 2019

yup that's fine

avatar infograf768
infograf768 - comment - 9 Feb 2019

The searchbox and, generally speaking, the overrides manager have been modified in 3.9.
Let's wait 3.9 is merged into 4.0 to take care of this.

avatar hardik-codes
hardik-codes - comment - 9 Feb 2019

So should I leave this issue untouched ?

avatar brianteeman
brianteeman - comment - 9 Feb 2019

If only j4 wasnt over 1000 commits behind staging life would be so much easier

avatar puneeth2001
puneeth2001 - comment - 26 Feb 2019

can I work on this issue now?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23798.

avatar hardik-codes
hardik-codes - comment - 26 Feb 2019

@puneeth2001 I'm already working on it and waiting for the commits to be merged

avatar infograf768
infograf768 - comment - 26 Feb 2019

Folks, I remind you that there were important changes in 3.8-9 for this feature and that it has not yet been ported to 4.0.
Look at a 3.9.3 site to see what we have there.
I suggest to wait until more stuff is ported to 4.0.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Mar 2019
Status New Discussion
avatar hardik-codes
hardik-codes - comment - 26 Mar 2019

@infograf768 I have got a patch ready should I submit it now ?

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Mar 2019
Status Discussion Information Required
avatar infograf768
infograf768 - comment - 27 Mar 2019

Be patient please...
#22107 has not been yet merged in 4.0
Once done, patch welcome, but please read the comments in that PR.

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Status Information Required Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Category com_search
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar C-Lodder
C-Lodder - comment - 10 Apr 2019

Closing as template team are working on backend template

avatar C-Lodder C-Lodder - change - 10 Apr 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-04-10 07:41:25
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 10 Apr 2019
avatar infograf768
infograf768 - comment - 11 Apr 2019

It concerns more than template.
Please test #24553

and read my note at the bottom of the description of the issue.

Add a Comment

Login with GitHub to post a comment