[#23782] - [4.0] fix wrong color of edit article
- Closed
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 23782
- Diff
- bahl24:publishcolor
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Signed-off-by: Nitish Bahl nitishbahl24@gmail.com
Pull Request for Issue #23781 .
Summary of Changes
Added class custom-select-color-state.
Expected result
Actual result
The values of different options is wrong due to which no color is displayed.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_content |
@puneet0191 @bembelimen @chmst @astridx Can you help?
the xml field in this case is of type="transition" and not type="list"
I would watch at https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Form/Field/TransitionField.php
You have to adjust https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_src/system/js/fields/select-colour.es6.js
so it handles the values of the NEW transition system...
@dgrammatiko In that file, the color is decided by the value only and as shown in the pic under actual result above, the current values are wrong.
@bahl24 exactly, that script was designed for the pre-transitions era. It needs to be refactored. Hint probably the select element needs to have a data attribute to make the distinction of plain select and the ones that used in the transitions. Should be very easy to patch...
HLeithner
- | Title |
|
||||||
@dgrammatiko @alikon
How can I add an attribute to the options select element. The transitionField.php returns this-
On choosing value changes but on saving the form the value field is ' ', No matter what option is selected publish/archive/unpublish
I added data-type="published" in article.xml but it is not added in select element.
So based on which condition should JS file differentiate?
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Removed:
J4 Issue
|
||
I have tested this item
Doesn't change anything
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23782.
I have tested this item
Doesn't change anything
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23782.
This is very out of date with the current branch.
| Closed_Date | 2019-05-04 18:43:56 | ⇒ | 2019-05-04 18:43:57 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 18:43:56 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23782
Closing for now until there is a proper fix.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23782.
I am facing difficulty in how to change the values of options, I tried adding-
<option value="1">JPUBLISHED</option> <option value="0">JUNPUBLISHED</option> <option value="2">JARCHIVED</option> <option value="-2">JTRASHED</option>but the form stops working as administrator/components/com_content/Model/ArticleModel.php is expecting transition value.
Anyone has any idea about how to change value of options as I have already added the class which decides color?