[#23780] - [4.0][NO CACHE] Convert Bootstrap tabs to CE
- Closed
- 2 Apr 2019
- Medium
- Build: 4.0-dev
- # 23780
- Diff
- dgrammatiko:4.0-dev-tabs
User tests: Successful: Unsuccessful:
Pull Request for Issue #22793 .
Summary of Changes
No boottrap interactive components...
Testing Instructions
Apply patch and check that the Global configuration page is working as intended
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
| Labels |
Added:
?
|
||
HAHAHA, I'm lazy and I copy pasted the lines from com content, didn't realised that were mixed...
@dgrammatiko You have a PHPCS Drone error
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23780.
What's the status on the new tabs code that replaces the existing missing functionality?
That functionality is useless, the new tabs support the disabled attribute per tab which is essentially the same thing so..
OK Well in that case you can remove the todo and commented out code if it has the same impact. Then this needs a test to ensure that is the case.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-02 11:08:19 |
| Closed_By | ⇒ | dgrammatiko |
I have tested this item✅ successfully on 9e42f15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23780.