? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Feb 2019

In Joomla 3.x we disabled the user links in the top right hand corner of the admin at the same time that we disabled the main menu. Amongst other reasons this was to prevent people from leaving an item checked out.

In Joomla 4 we have now have several icons in this place (users, private-messages, post-installation, multilingual status, preview) and these are from the status module and the multilingual status module.

Nothing needs to be changed with the multilingual status module as this opens in a model and preview is also ok because it opens a new tab.

But users, private-messages, post-installation all need to be disabled when an item is open to prevent the item being left checked out.

In J3 and in J4 we have code for this $app->input->get('hidemainmenu');

In J4 the variable is declared but never used - whoops :)

This PR fixes that.

Test

Open an article and ensure that only the "preview" and if enabled "multilingual status" links work
Close the article and ensure that all of them work.

Note

The template design team might want to change the icon or styling when it is disabled but that's beyond the scope of this PR.

avatar brianteeman brianteeman - open - 2 Feb 2019
avatar brianteeman brianteeman - change - 2 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2019
Category Modules Administration
avatar brianteeman brianteeman - change - 2 Feb 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 4 Feb 2019

Thanks @Quy

avatar Quy
Quy - comment - 4 Feb 2019

I have tested this item successfully on 457b3ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23752.

avatar Quy Quy - test_item - 4 Feb 2019 - Tested successfully
avatar wilsonge wilsonge - close - 27 Feb 2019
avatar wilsonge wilsonge - merge - 27 Feb 2019
avatar wilsonge wilsonge - change - 27 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-27 19:40:55
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 27 Feb 2019

Thanks!

avatar brianteeman
brianteeman - comment - 27 Feb 2019

Thanks

Add a Comment

Login with GitHub to post a comment