User tests: Successful: Unsuccessful:
Signed-off-by: Nitish Bahl nitishbahl24@gmail.com
Pull Request for Issue # . Notice inconsistency in format of btn-toolbar, sometimes it wraps and sometimes not as shown below
I feel that the toolbar should not wrap as it looks odd, thus I have added nowrap
which fixes the issue
Options and help button on same line.
Buttons are on different lines, may be more problematic if more buttons are added in the future.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Title |
|
Title |
|
@puneet0191 @yvesh @astridx It is my first PR in Joomla Dev, can you help me out in #23749 (comment) and why Drone CI has failed?
Labels |
Added:
?
|
I noticed that there is no margin between bulk import and options button due to
margin-left: auto!important;
which overidesmargin-left: .75rem;
Is there a way we can choose max of the two values?
You have pointed here the issue with this PR.
the class .ml-auto
overrides .subhead .btn-toolbar
an therefore the Options toolbar button gets stuck to whatever toolbar we have before it when reducing the browser window.
There is no min or max-margin in CSS and I am not sure we can use percentages here.
@infograf768 Is there any other work around for this problem. I think that if we insert margin-right for the button before option button, we can solve this. Correct me if I am wrong.
Indeed, if we do
.btn-toolbar {
margin-bottom: 0;
flex-wrap: nowrap;
> * {
margin-right: .75rem;
box-shadow: $atum-box-shadow;
&:last-child {
margin-right: 0;
}
}
}
It would work.
And then we also have to modify stuff for RTL.
But the problem is anyway present when one reduces the window size to accomodate tablets and smartphones... The toolbar buttons display far away from the view...
After patch
Before patch
I think that the solution is much more complex and includes a complete refactoring of the toolbar.
@coolcat-creations
@infograf768 I think you are right
Putting this on our list...
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-21 04:23:08 |
Closed_By | ⇒ | Quy |
Closing as not reproducible with the new backend template.
I noticed that there is no margin between bulk import and options button due to
margin-left: auto!important;
which overidesmargin-left: .75rem;
Is there a way we can choose max of the two values?
I am new to Joomla Dev and tried putting a if statement in the sass file, but I am facing problems.