? Failure

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
2 Feb 2019

Signed-off-by: Nitish Bahl nitishbahl24@gmail.com

Pull Request for Issue # . Notice inconsistency in format of btn-toolbar, sometimes it wraps and sometimes not as shown below
screenshot from 2019-02-02 17-07-53
screenshot from 2019-02-02 17-07-28

Summary of Changes

I feel that the toolbar should not wrap as it looks odd, thus I have added nowrap which fixes the issue

Expected result

Options and help button on same line.

Actual result

Buttons are on different lines, may be more problematic if more buttons are added in the future.
screenshot from 2019-02-03 03-15-07

Documentation Changes Required

None

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar bahl24 bahl24 - open - 2 Feb 2019
avatar bahl24 bahl24 - change - 2 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2019
Category Administration Templates (admin)
avatar HLeithner HLeithner - change - 2 Feb 2019
Title
Fixes wrapping of btn-toolbar
[4.0] Fixes wrapping of btn-toolbar
avatar HLeithner HLeithner - edited - 2 Feb 2019
avatar HLeithner HLeithner - change - 2 Feb 2019
Title
Fixes wrapping of btn-toolbar
[4.0] Fixes wrapping of btn-toolbar
avatar bahl24
bahl24 - comment - 2 Feb 2019

I noticed that there is no margin between bulk import and options button due to margin-left: auto!important; which overides margin-left: .75rem;
Is there a way we can choose max of the two values?
I am new to Joomla Dev and tried putting a if statement in the sass file, but I am facing problems.

avatar bahl24
bahl24 - comment - 3 Feb 2019

@puneet0191 @yvesh @astridx It is my first PR in Joomla Dev, can you help me out in #23749 (comment) and why Drone CI has failed?

avatar wojsmol
wojsmol - comment - 3 Feb 2019

@bahl24 Regarding dron please merge latest changes from joomla-cms/4.0-dev to this PR branch.

avatar bahl24 bahl24 - change - 3 Feb 2019
Labels Added: ?
avatar bahl24
bahl24 - comment - 3 Feb 2019

@wojsmol Done

avatar infograf768
infograf768 - comment - 5 Feb 2019

I noticed that there is no margin between bulk import and options button due to margin-left: auto!important; which overides margin-left: .75rem;
Is there a way we can choose max of the two values?

You have pointed here the issue with this PR.
the class .ml-auto overrides .subhead .btn-toolbar an therefore the Options toolbar button gets stuck to whatever toolbar we have before it when reducing the browser window.

There is no min or max-margin in CSS and I am not sure we can use percentages here.

avatar bahl24
bahl24 - comment - 5 Feb 2019

@infograf768 Is there any other work around for this problem. I think that if we insert margin-right for the button before option button, we can solve this. Correct me if I am wrong.

avatar infograf768
infograf768 - comment - 7 Feb 2019

Indeed, if we do

.btn-toolbar {
    margin-bottom: 0;
    flex-wrap: nowrap;
    > * {
      margin-right: .75rem;
      box-shadow: $atum-box-shadow;

      &:last-child {
        margin-right: 0;
      }
    }
}

It would work.
And then we also have to modify stuff for RTL.

avatar infograf768
infograf768 - comment - 7 Feb 2019

But the problem is anyway present when one reduces the window size to accomodate tablets and smartphones... The toolbar buttons display far away from the view...
After patch
screen shot 2019-02-07 at 11 34 07
Before patch
screen shot 2019-02-07 at 11 37 04

I think that the solution is much more complex and includes a complete refactoring of the toolbar.
@coolcat-creations

avatar bahl24
bahl24 - comment - 7 Feb 2019

@infograf768 I think you are right

avatar coolcat-creations
coolcat-creations - comment - 6 Mar 2019

Putting this on our list...

avatar Quy Quy - change - 21 Jul 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-07-21 04:23:08
Closed_By Quy
avatar Quy Quy - close - 21 Jul 2019
avatar Quy
Quy - comment - 21 Jul 2019

Closing as not reproducible with the new backend template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23749.

Add a Comment

Login with GitHub to post a comment