Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23737] - [4.0] [WIP] Links to buttons

J4 Issue ?
avatar zwiastunsw
zwiastunsw
1 Feb 2019

In alpha6 version I found 15 files in which instead of the tag button was used the a tag with the attribute role=button. We have already explained that this is an accessibility error that needs to be fixed.
Could anyone improve these files?
It has already happened that @SharkyKZ corrected a number of errors of this type in one PR (#22494)
Below is a list of them.

  • administrator/components/com_asotiations/Field/Modal/AsotiationsField.php
  • administrator/components/com_categoies/Field/Modal/CategoryField.php
  • administrator/components/com_contact/Field/Modal/ContactField.php
  • administrator/components/com_content/Field/Modal/ArticleField.php
  • administrator/components/com_content/View/Article/HtmlView.php
  • administrator/components/com_fields/Field/Modal/FieldField.php
  • administrator/components/com_media/resources/scripts/components/modals/share-modal.vue
  • administrator/components/com_menus/tmpl/item/edit_modules.php
  • administrator/components/com_menus/tmpl/menus/default.php
  • administrator/components/com_newsfeeds/Field/Modal/NewsfeedField.php
  • administrator/components/com_templates/Service/HTML/Templates.php
  • administrator/modules/mod_logged/tmpl/default.php
  • administrator/modules/mod_multilangstatus/tmpl/default.php
  • installation/tmpl/remove/default.php
  • layouts/joomla/toolbar/versions.php
    I did not check, but I suppose similar changes are needed in Joomla3.
avatar zwiastunsw zwiastunsw - open - 1 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Feb 2019
avatar zwiastunsw zwiastunsw - change - 1 Feb 2019
The description was changed
avatar zwiastunsw zwiastunsw - edited - 1 Feb 2019
avatar brianteeman
brianteeman - comment - 1 Feb 2019

i strongly suspect that these have all been fixed in 3.9 by @SharkyKZ and are just waiting for @wilsonge to merge them into j4. j4 is currently over 1000 commits behind/

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Mar 2019
Status New ⇒ Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Mar 2019
Category ⇒ Accessibility
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2019
Category Accessibility ⇒
avatar brianteeman
brianteeman - comment - 16 Apr 2019

i can see that these are still present BUT most are for modal close buttons which is scheduled to be rewritten. I will do a pr for the rest

avatar wilsonge wilsonge - reference | 51ecd73 - 17 Apr 19
avatar wilsonge wilsonge - change - 17 Apr 2019
The description was changed
avatar wilsonge wilsonge - edited - 17 Apr 2019
avatar wilsonge wilsonge - change - 17 Apr 2019
The description was changed
avatar wilsonge wilsonge - edited - 17 Apr 2019
avatar wilsonge wilsonge - reference | 9763467 - 17 Apr 19
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
…
[4.0][a11y] Links to buttons
[4.0] [WIP] Links to buttons
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
…
[4.0][a11y] Links to buttons
[4.0] [WIP] Links to buttons
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar Quy
Quy - comment - 13 May 2019

Please confirm that this can be closed.

avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
The description was changed
avatar wilsonge wilsonge - edited - 13 May 2019
avatar wilsonge
wilsonge - comment - 13 May 2019

Looks like 3 files left to me

avatar Quy
Quy - comment - 8 Jun 2019

Related PR #23740

avatar Quy
Quy - comment - 8 Jun 2019

Deleted in PR #25139.
administrator/components/com_fields/Field/Modal/FieldField.php

Fixed in PR #25126
administrator/components/com_menus/tmpl/menus/default.php
administrator/modules/mod_multilangstatus/tmpl/default.php

avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2019
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-06-08 21:56:36
Closed_By ⇒ joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 8 Jun 2019
avatar Quy Quy - change - 8 Jun 2019
Closed_By joomla-cms-bot ⇒ Quy
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 8 Jun 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 8 Jun 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23737

Add a Comment

Login with GitHub to post a comment