Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23716] - [4.0] Fix: Saving menu item fails. Call to a member function validate() on bool. Field "show_associations"

? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
30 Jan 2019

Pull Request for Issue #23696

Related and already merged fix: #23501

I think this is a better alternative fix to #23700 ?

Testing Instructions

Install a J4 nightly build of today (Monday, 28 January 2019) or update an older J4 with that package

Go to menu items manager in back-end.

Open Home menu item (type "Articles > Featured Articles")

Save it.

Error like described in #23696 (comment)

Apply patch

Try again to save the menu item.

Should be successful.

avatar wilsonge wilsonge - open - 30 Jan 2019
avatar wilsonge wilsonge - change - 30 Jan 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2019
Category ⇒ Unit Tests Repository External Library Composer Change Libraries
avatar wilsonge wilsonge - change - 30 Jan 2019
Labels Added: ? ? ?
avatar SharkyKZ
SharkyKZ - comment - 30 Jan 2019

Need the same in filter().

avatar wilsonge wilsonge - change - 30 Jan 2019
Labels Removed: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2019
Category Unit Tests Repository External Library Composer Change Libraries ⇒ Libraries
avatar wilsonge
wilsonge - comment - 30 Jan 2019

@SharkyKZ fixed :)

avatar ReLater
ReLater - comment - 30 Jan 2019

I have tested this item ✅ successfully on c1e7e3b

Saving of articles works, too. After reverting pr #23501

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.

avatar ReLater ReLater - test_item - 30 Jan 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 30 Jan 2019

Saving of articles works, too. After reverting pr #23501

How is that? We still miss merging #23638
here I get

Error
Save failed with the following error: Incorrect integer value: '' for column 'hits' at row 1

why revert #23501 ?

avatar infograf768
infograf768 - comment - 30 Jan 2019

I have tested this item ✅ successfully on 2102697

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.

avatar infograf768 infograf768 - test_item - 30 Jan 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 30 Jan 2019

@ReLater
Why reverting #23501 ? I tested here after disabling languagefilter and therefore show_associations not displaying when editing article Options grace to #23501 and it works fine.

avatar ReLater
ReLater - comment - 30 Jan 2019

@infograf768

why revert #23501 ?

Because I could create/save Articles, too, after reverting ONLY these lines of #23501:

// Remove show_associations field if associations is not enabled
		if (!$assoc)
		{
			$form->removeField('show_associations', 'attribs');
		}

So, I think that we don't need the additional fix in 23501 anymore with this pr here. Wasn't that one of the purposes of the discussion about "hardcoded field names"?

avatar ReLater
ReLater - comment - 30 Jan 2019

And the show_associations field is not displayed in a mono-lang page in article edit form.

avatar infograf768
infograf768 - comment - 31 Jan 2019

@ReLater
Yep, you are right. We can now delete the lines you quote above as the AssocField take care of that.
@wilsonge
Can you add that to your PR?

avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2019
Category Libraries ⇒ Administration com_content Libraries
avatar wilsonge
wilsonge - comment - 4 Feb 2019

PR Amended

avatar infograf768
infograf768 - comment - 4 Feb 2019

I have tested this item ✅ successfully on b2eca8e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.

avatar infograf768 infograf768 - test_item - 4 Feb 2019 - Tested successfully
avatar alikon
alikon - comment - 5 Feb 2019

I have tested this item ✅ successfully on 4a69575

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.

avatar alikon alikon - test_item - 5 Feb 2019 - Tested successfully
avatar infograf768 infograf768 - change - 5 Feb 2019
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 5 Feb 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.

avatar Bakual Bakual - change - 6 Feb 2019
Labels Added: ?
avatar Bakual Bakual - alter_testresult - 6 Feb 2019 - alikon: Tested successfully
avatar Bakual Bakual - alter_testresult - 6 Feb 2019 - infograf76: Tested successfully
avatar Bakual Bakual - change - 6 Feb 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-02-06 07:09:40
Closed_By ⇒ Bakual
avatar Bakual Bakual - close - 6 Feb 2019
avatar Bakual Bakual - merge - 6 Feb 2019

Add a Comment

Login with GitHub to post a comment