[#23706] - [4.0] Fixed module position names on medium-width screens
- Closed
- 5 Jul 2019
- Medium
- Build: 4.0-dev
- # 23706
- Diff
- hardik-codes:modulePosition
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23451
Summary of Changes
Changes in file administrator/language/en-GB/en-GB.ini and media/vendor/choicesjs/css/choices.min.css
Testing Instructions
Open existing or create new module.
Resize (desktop) screen to about half width but so that position list is still to the right of the editor, not below.
Click the Position drop-down menu to view list of module positions
Expected result (Now)
Actual result (Earlier)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23706.
@brianteeman Please suggest me the changes.
Removing necessary text is not a solution. You need to find a solution that doesnt remove the text. The change should probably require a media query so you are only applying it at the screen sizes that are impacted and not on all screen sizes
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings | ⇒ |
| Labels |
Removed:
?
|
||
@brianteeman please review the changes.
@hardik-codes Not sure where to start. You are trying to commit a file that doesnt exist in the repository. Thats because it is a VENDOR file which is not committed to the repo but generated by our build tools. And its pretty much a golden rule that you never edit a vendor file
@brianteeman sorry I didn't know about that. Then what could possibly be the other way round to implement those changes ?
If I read your css change correctly it is doing what I said shouldnt be done
Removing necessary text is not a solution. You need to find a solution that doesnt remove the text.
@brianteeman I haven't removed the necessary text in the latest commits. All I have done is added media queries to achieve the desired effect
Maybe I misread your code but doesnt this code remove the text "Press to select" ?
@media (min-width: 768px) and (max-width: 1024px) {
.choices__list--dropdown .choices__item--selectable:after {
content: none;
}
}
@brianteeman Yeah it does so. What I thought (as per your above guideline) was that "Press to select" was to be removed for only some screen sizes and not all as for only some screen sizes the result was like this
@brianteeman please suggest me the changes to improve this PR
franz-wohlkoenig
- | Category | ⇒ | com_modules |
| Title |
|
||||||
| Category | com_modules | ⇒ |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-05 15:48:48 |
| Closed_By | ⇒ | Quy |
Closing since this is not a proper fix as vendor files should not be modified.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23706.
This is not a correct fix