? ? ? Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
28 Jan 2019

Pull Request for Issue #23041 .

Summary of Changes

Moved the generic "does the database name start with a letter"-check into a more specific condition, where it's connected with postgresql. For MySQL, a more generic check is implemented (no \ / . characters allowed).

Testing Instructions

Try to install Joomla into a database that starts with a number as first character. You'll get an error. Apply the patch and retry, the error is now gone.

Expected result

Works

Actual result

Error is thrown

Documentation Changes Required

None

avatar SniperSister SniperSister - open - 28 Jan 2019
avatar SniperSister SniperSister - change - 28 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2019
Category Installation
avatar infograf768 infograf768 - change - 28 Jan 2019
Title
Fix database name validation for MySQL in installation app
[4.0] Fix database name validation for MySQL in installation app
avatar infograf768 infograf768 - edited - 28 Jan 2019
avatar alikon
alikon - comment - 28 Jan 2019

I have tested this item successfully on b4bad80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.

avatar alikon alikon - test_item - 28 Jan 2019 - Tested successfully
avatar wojsmol
wojsmol - comment - 28 Jan 2019

@SniperSister Please make dron happy.

avatar SniperSister SniperSister - change - 28 Jan 2019
Labels Added: ?
avatar chmst
chmst - comment - 29 Jan 2019

I have tested this item ? unsuccessfully on 88a7cf6

I am working in a local environment using xampp and MariaDB. Here it is not necessary to install a new database, the installer uses to install it. Here the rule is still active.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.

avatar chmst
chmst - comment - 29 Jan 2019

I have tested this item ? unsuccessfully on 88a7cf6

I am working in a local environment using xampp and MariaDB. Here it is not necessary to install a new database, the installer uses to install it. Here the rule is still active.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.

avatar chmst chmst - test_item - 29 Jan 2019 - Tested unsuccessfully
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2019
Category Installation Installation Language & Strings
avatar SniperSister
SniperSister - comment - 29 Jan 2019

@flo1212 @chmst I updated the PR accordingly, please retest

avatar flo1212
flo1212 - comment - 29 Jan 2019

I have testet this patch 0df73fb successfully

avatar ghazal
ghazal - comment - 29 Jan 2019

I have tested this item successfully on 0df73fb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.

avatar ghazal ghazal - test_item - 29 Jan 2019 - Tested successfully
avatar chmst
chmst - comment - 29 Jan 2019

I have tested this item successfully on 0df73fb

Successful with xampp, Maridb, win10.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.
avatar chmst
chmst - comment - 29 Jan 2019

I have tested this item successfully on 0df73fb

Successful with xampp, Maridb, win10.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.
avatar chmst chmst - test_item - 29 Jan 2019 - Not tested
avatar chmst chmst - test_item - 29 Jan 2019 - Tested successfully
avatar chmst chmst - test_item - 29 Jan 2019 - Tested successfully
avatar Quy Quy - change - 29 Jan 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.

avatar Quy
Quy - comment - 29 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23704.

avatar wilsonge wilsonge - change - 2 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-02 16:34:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Feb 2019
avatar wilsonge wilsonge - merge - 2 Feb 2019
avatar wilsonge
wilsonge - comment - 2 Feb 2019

Thanks!

avatar wilsonge
wilsonge - comment - 2 Feb 2019

@SniperSister We need to adapt the com_config filter to use this too please

Add a Comment

Login with GitHub to post a comment