? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
28 Jan 2019

Pull Request for Issue #23464 .

Summary of Changes

Set the uncategories category workflow selection to "use default" as described in the issue.

Testing Instructions

See #23464

avatar bembelimen bembelimen - open - 28 Jan 2019
avatar bembelimen bembelimen - change - 28 Jan 2019
Status New Pending
avatar bembelimen bembelimen - change - 28 Jan 2019
Title
Workflow preinstalled default category
[4.0] Workflow preinstalled default category
avatar bembelimen bembelimen - edited - 28 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2019
Category SQL Installation Postgresql
avatar brianteeman
brianteeman - comment - 28 Jan 2019

I have tested this item successfully on 8e1275c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23701.

avatar brianteeman brianteeman - test_item - 28 Jan 2019 - Tested successfully
avatar wojsmol
wojsmol - comment - 28 Jan 2019

@zero-24 Please fix rips issue.

avatar brianteeman
brianteeman - comment - 29 Jan 2019

Just wondering what happens when you upgrade from j3 as they don't have a work flow set. Would it be better to not store anything in the category if it's going to be "use default" and instead make the code use default if no workflow is set.

avatar bembelimen bembelimen - change - 29 Jan 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 29 Jan 2019

Sorry you misunderstood me. It is indeed available but its not applied to all existing categories because it needs to be saved as "workflow_id":"use_default" in the params field. That would mean opening every category and saving it again to set the value. Unless I have misunderstood the code (and I might have) I am suggesting that if there is no workflow_id set then it will default to "use_default"

avatar bembelimen
bembelimen - comment - 29 Jan 2019

Ah, now I understand, the expected default of the select is "use_default" (https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/forms/category.xml#L18).

When no workflow is assinged to the category, it falls back to the default one: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/Model/ArticleModel.php#L1296

avatar brianteeman
brianteeman - comment - 29 Jan 2019

so to be clear this pr could also have simply removed the "workflow_id":"1" instead of changing it to "workflow_id":"use_default"

thats what confused me

avatar bembelimen
bembelimen - comment - 29 Jan 2019

Yes, that would have been working, too.

avatar brianteeman
brianteeman - comment - 29 Jan 2019

Now its clear - thanks

avatar wilsonge wilsonge - change - 30 Jan 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-30 09:03:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jan 2019
avatar wilsonge wilsonge - merge - 30 Jan 2019
avatar wilsonge
wilsonge - comment - 30 Jan 2019

Thanks!

Add a Comment

Login with GitHub to post a comment