User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Similar to PR #23685 for Joomla 4.
The 'nav' tag defines one of the main landmarks of the page, and the aria-label attribute makes it possible to distinguish this landmark from other navigation points, e.g. general menu.
Landmarks are supported by assistive technologies. Users of screen readers use them as one of the navigation systems on the page.
Assistive technology does not recognize the breadcrumb as a landmark.
In the Help screens
Include information that the title of the module is used as a label for assistive technologies, so it should be translated (since the title of this module is not displayed, administrators often leave it in English).
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
Sorry but you don't actually understand what the text you are quoting refers to.
The nav element is not exposed in the accessibility tree with internet explorer.
What you are seeing is that NVDA (and perhaps other screen readers have written a workaround to this IE bug) See nvaccess/nvda#6044
This only means that an NVDA and IE11 user is helped. It doesn't fix the bug in IE11 which we have no way of knowing if other assistive technology has their own work around.
So the correct conclusion is to have the role so that ALL users of assistive technology and IE 11 are covered.
We only support specific browsers. We do not support specific assistive technology
I am sorry. I don't know why you assume that I don't understand something. Maybe it' s you who don't understand something?
I wrote what my opinion is. I am free to have my opinion. At the same time I did a successful test.
Please see the new W3C WAI page.
https://www.w3.org/WAI/
Please check in the code that the new HTML5 tags (header, nav, main, footer, etc) are used without the role=" attribute.
Of course, you can say that W3C WAI does wrong. For me this is the correct pattern.
Using these tags (which have an implicitly entered role) without role attributes is correct (and not, as you say, incorrect). Even if some technologies do not support these tags yet.
Sorry I can't help it if you don't understand the difference between the html 5 specification and the browsers implementation of it and it's the accessibility html5 mapping specification aka html-aam
@brianteeman believe me, I understand.
@HLeithner
For 3.x if it. Is changed to div role=navigation it will not break anything and it will be more accessible than it was before
This PR adds a NAV-tag around the UL-tag and this can break templates.
Yes which is why I wrote what I wrote
Maybe break less but why can't it be added to the UL?
it can be but it would be invalid html
nav
tag damage existing templates? The Breadcrumb is stylized with the breadcrumb
class. Of course, it is always possible that some inexperienced webmaster will use some special formatting for the 'nav' tag. But we won't be able to do that.role="navigation"
to div
tag is not an error if you cannot use nav
tag (for ex. in HTML4 document), but adding to ul
tag is the error! But there is no justification here that excludes the use of nav
tag.6.1.7 Rendered markup
For the time being, rendered markup is not subject to our backwards compatibility promise. We will try not to change markup in such a way that a site might render differently, but we can't promise not to break anything at the present time. We will work on defining ways in which we might make a backwards compatibility promise for markup in the future, but we do not currently have a satisfactory consensus on a workable standard.
https://developer.joomla.org/development-strategy.html
Labels |
Added:
?
|
I have tested this item
I have tested this item
You cant close a div with a nav :(
@zwiastunsw how did you successfully test - the markup is wrong
Yes, my mistake.
I have tested this item
now is OK
I have tested this item
Thats better - thanks
I have tested this item
Thats better - thanks
Status | Pending | ⇒ | Ready to Commit |
RTC
@HLeithner Please merge this PR, nav
was changed to div
as requested.
I requested a different change that seams not to be vaild, thats the reason I didn't merged it.
@HLeithner This PR now adapt changes suggested ny @brianteeman in #23691 (comment) see https://github.com/joomla/joomla-cms/pull/23691/files?utf8=%E2%9C%93&diff=unified&w=1
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-09 16:24:40 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
I merge it anyway, thx
I have tested this item✅ successfully on 7bf3f2f
In my opinion, the
role="navigation"
attribute is unnecessary. You can leave it. But all popular browsers, including IE11, recognize thenav
tag.Nav
tag hasrole=navigation
implicite entered. Leaving an attribute, however, will not be an error. In the W3C WAI tutorial, it is still recommended to place a redundant attribute of a role.See: https://www.w3.org/WAI/tutorials/page-structure/regions/ :
Personally, I am against entering a role attribute. But because we did this in other cases (e.g. in the pagination.php file), let it stay.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23691.