? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
27 Jan 2019

Pull Request for Issue #23680 .

Summary of Changes

modified_time check added

Testing Instructions

see #23680

Expected result

save/create custom field work

Actual result

error

Documentation Changes Required

avatar alikon alikon - open - 27 Jan 2019
avatar alikon alikon - change - 27 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2019
Category Administration com_fields
avatar ghazal
ghazal - comment - 27 Jan 2019

I have tested this item successfully on f4364c0

NB: for some obscure reason, patchtester would not apply this correction, had to add it manually. But it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23689.

avatar ghazal ghazal - test_item - 27 Jan 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 27 Jan 2019

@zero-24 @SniperSister RIPS Please

avatar infograf768
infograf768 - comment - 28 Jan 2019

I have tested this item successfully on f4364c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23689.

avatar infograf768 infograf768 - test_item - 28 Jan 2019 - Tested successfully
avatar infograf768 infograf768 - change - 28 Jan 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 28 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23689.

avatar infograf768 infograf768 - change - 28 Jan 2019
Labels Added: ?
avatar laoneo laoneo - change - 31 Jan 2019
Labels Added: ?
avatar laoneo
laoneo - comment - 31 Jan 2019

Any idea why this is needed all of the sudden?

avatar wilsonge
wilsonge - comment - 3 Feb 2019

It's probably been there since the start of 4.0 when we did the extra strict rules on sql fields in #12494

We had to do similar fixes in various other components at the time

avatar wilsonge wilsonge - close - 5 Feb 2019
avatar wilsonge wilsonge - merge - 5 Feb 2019
avatar wilsonge wilsonge - change - 5 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-05 00:26:32
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 5 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment