User tests: Successful: Unsuccessful:
Pull Request for Issue #23627 .
class="row" changed to
class="col-md-12"
Go to the "Permissions" tab in Global Configuration
It should be aligned
the containers aren't aligned
NO
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config |
Labels |
Added:
?
|
Yup, this fixes the inconsistency with the row
class
Actually it's due to the row
class on the <joomla-field-permissions>
custom element (no idea why it's there).
Then you'll need to replace your current coding changes with:
<div class="row">
<div class="col-md-12">
</div>
</div>
EDIT: Aaah, sorry! I skipped #23687 (comment)
Is there a reason why you don't remove row
class here: https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/form/field/rules.php#L78
plus
<div id="page-permissions" class="tab-pane">
<div class="row">
<div class="col-md-12">
....
in default.php.
Thus you could make the code inside default.php more consistent.
I've tested my proposal a bit in the back-end and I think the row
class for joomla-field-permissions
is wrong(?).
Category | Administration com_config | ⇒ | Administration com_config Layout |
@amitranjan2 Your latest commit is incorrect.
@amitranjan2 Re-add this: <joomla-field-permissions class="row mb-2" data-uri="<?php echo $ajaxUri; ?>">
but remove row
from it.
Then for the width, this will need to be fixed in the SCSS file.
@amitranjan2 You did not do the changes as proposed by C-Lodder.
Category | Administration com_config Layout | ⇒ | Administration com_config |
Category | Administration com_config | ⇒ | Administration com_config Layout |
@amitranjan2 No, my PR was purely for code improvements
Is this correct ?
Good start. It should align with the Permissions
blue blox. And I think the tabs on ther left need sorting out. If I righgtly remember, they 30% width which may look somewhat odd, higher resolution monitors
@C-Lodder I made changes in joomla-tab.css and this is the result
here I changed to min-width:15%
https://github.com/joomla-projects/custom-elements/blob/a0cb122751530fb093b74319899fef5fe377a808/src/scss/tab/tab.scss#L78
is this all correct now?
alignment and 100% width both
Code changes seem fine
You can incorporate them here or do a separate one. Your choice
Title |
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-07 22:03:41 |
Closed_By | ⇒ | Quy |
Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23687
This is no longer an issue with the new backend template.
@C-Lodder please review this