J4 Issue ? Success

User tests: Successful: Unsuccessful:

avatar amitranjan2
amitranjan2
26 Jan 2019

Pull Request for Issue #23627 .

Summary of Changes

class="row" changed to
class="col-md-12"

Testing Instructions

Go to the "Permissions" tab in Global Configuration

Expected result

It should be aligned

Actual Result

the containers aren't aligned

Documentation Changes Required

NO

avatar amitranjan2 amitranjan2 - open - 26 Jan 2019
avatar amitranjan2 amitranjan2 - change - 26 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2019
Category Administration com_config
avatar amitranjan2 amitranjan2 - change - 26 Jan 2019
Labels Added: ?
avatar amitranjan2
amitranjan2 - comment - 26 Jan 2019

@C-Lodder please review this

avatar C-Lodder
C-Lodder - comment - 26 Jan 2019

Yup, this fixes the inconsistency with the row class

7688470 27 Jan 2019 avatar amitranjan2 fix
avatar amitranjan2
amitranjan2 - comment - 27 Jan 2019

@C-Lodder could you please help me? which container need to be 100%

avatar C-Lodder
C-Lodder - comment - 27 Jan 2019

Actually it's due to the row class on the <joomla-field-permissions> custom element (no idea why it's there).

Then you'll need to replace your current coding changes with:

<div class="row">
    <div class="col-md-12">
    </div>
</div>
avatar ReLater
ReLater - comment - 30 Jan 2019

EDIT: Aaah, sorry! I skipped #23687 (comment)

Already said above:

Is there a reason why you don't remove row class here: https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/form/field/rules.php#L78

plus

<div id="page-permissions" class="tab-pane">
  <div class="row">
    <div class="col-md-12">
....

in default.php.

Thus you could make the code inside default.php more consistent.

I've tested my proposal a bit in the back-end and I think the row class for joomla-field-permissions is wrong(?).

avatar C-Lodder
C-Lodder - comment - 30 Jan 2019

@ReLater Yes, the row class on the custom element is incorrect. It shouldn't be there at all.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2019
Category Administration com_config Administration com_config Layout
avatar C-Lodder
C-Lodder - comment - 30 Jan 2019

@amitranjan2 Your latest commit is incorrect.

avatar amitranjan2
amitranjan2 - comment - 30 Jan 2019

@C-Lodder was previous one right?
I'm working on this issue for a quite long time, still not getting the 100% width

avatar C-Lodder
C-Lodder - comment - 30 Jan 2019

@amitranjan2 Re-add this: <joomla-field-permissions class="row mb-2" data-uri="<?php echo $ajaxUri; ?>">

but remove row from it.

Then for the width, this will need to be fixed in the SCSS file.

8c2d45a 30 Jan 2019 avatar amitranjan2 fix
avatar Quy
Quy - comment - 31 Jan 2019

@amitranjan2 You did not do the changes as proposed by C-Lodder.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2019
Category Administration com_config Layout Administration com_config
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2019
Category Administration com_config Administration com_config Layout
avatar amitranjan2
amitranjan2 - comment - 31 Jan 2019

@Quy I revert the changes according to @C-Lodder

avatar amitranjan2
amitranjan2 - comment - 31 Jan 2019

@C-Lodder is scss file changes already done in your PR ? #23729

avatar C-Lodder
C-Lodder - comment - 31 Jan 2019

@amitranjan2 No, my PR was purely for code improvements

bd12497 31 Jan 2019 avatar amitranjan2 fix
avatar amitranjan2
amitranjan2 - comment - 2 Feb 2019
avatar amitranjan2
amitranjan2 - comment - 2 Feb 2019

Is this correct ?

avatar C-Lodder
C-Lodder - comment - 2 Feb 2019

Good start. It should align with the Permissions blue blox. And I think the tabs on ther left need sorting out. If I righgtly remember, they 30% width which may look somewhat odd, higher resolution monitors

avatar amitranjan2
amitranjan2 - comment - 5 Feb 2019

@C-Lodder I made changes in joomla-tab.css and this is the result
here I changed to min-width:15%
https://github.com/joomla-projects/custom-elements/blob/a0cb122751530fb093b74319899fef5fe377a808/src/scss/tab/tab.scss#L78
image

is this all correct now?
alignment and 100% width both

avatar amitranjan2
amitranjan2 - comment - 6 Feb 2019

@C-Lodder is anything left to be fixed?
please tell me.
in my opinion, your both issue(alignment and 100% width) is working fine now.
please review

avatar C-Lodder
C-Lodder - comment - 6 Feb 2019

Code changes seem fine

avatar amitranjan2
amitranjan2 - comment - 6 Feb 2019

@C-Lodder So, have I to create another PR for that changes of width in Joomla project/Custom elements?

avatar C-Lodder
C-Lodder - comment - 7 Feb 2019

You can incorporate them here or do a separate one. Your choice

avatar amitranjan2
amitranjan2 - comment - 10 Feb 2019

@C-Lodder Please close the Issue #23627
as now both alignment and width 100% is working fine

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[FIX][4.0] Global Config Permissions inconsistent widths
[4.0] Global Config Permissions inconsistent widths
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar Quy Quy - change - 7 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-07 22:03:41
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2019
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 7 May 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 7 May 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23687

avatar Quy
Quy - comment - 7 May 2019

This is no longer an issue with the new backend template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23687.

Add a Comment

Login with GitHub to post a comment