? Success

User tests: Successful: Unsuccessful:

avatar chmst
chmst
26 Jan 2019

Summary of Changes

Add a landmark NAV to bredcrumbs module to improve navigation

Testing Instructions

View sourcecode before and after patch.

avatar chmst chmst - open - 26 Jan 2019
avatar chmst chmst - change - 26 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2019
Category Modules Front End
avatar chmst chmst - change - 26 Jan 2019
The description was changed
avatar chmst chmst - edited - 26 Jan 2019
avatar zwiastunsw
zwiastunsw - comment - 26 Jan 2019

I have tested this item successfully on bcaab10

avatar zwiastunsw zwiastunsw - test_item - 26 Jan 2019 - Tested successfully
avatar wojsmol
wojsmol - comment - 26 Jan 2019

I have tested this item successfully on bcaab10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.

avatar wojsmol wojsmol - test_item - 26 Jan 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 27 Jan 2019

@zero-24 @SniperSister rips please

avatar zero-24
zero-24 - comment - 27 Jan 2019
avatar zero-24
zero-24 - comment - 27 Jan 2019

Rips and drone are happy now.

avatar brianteeman
brianteeman - comment - 27 Jan 2019

Sorry this is not correct. As we still support IE 11 it is required to also have role=navigation

See https://www.drupal.org/project/drupal/issues/2655764#comment-11322013
and https://www.html5accessibility.com/#support

avatar zwiastunsw
zwiastunsw - comment - 27 Jan 2019

I tested in Windows 10 and Internet Explorer 11 with NVDA. IE11 supports tag nav. Screen reader announces a landmark.

avatar chmst
chmst - comment - 27 Jan 2019

I asked https://caniuse.com/#search=nav
It seems that all modern browsers support the nav tag.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.
avatar brianteeman
brianteeman - comment - 27 Jan 2019

caniuse doesnt cover the accessibility tree ;)

according to all the docs i can find online ie11 doesnt support it. Although I can confirm Stefan results

avatar zwiastunsw
zwiastunsw - comment - 27 Jan 2019

My proposal:

  • in Joomla 4 do not add a redundant attribute role.
  • in Joomla 3 leave, as in other cases (e.g. pagination.php. )
avatar chmst chmst - change - 27 Jan 2019
Labels Added: ?
avatar zwiastunsw
zwiastunsw - comment - 27 Jan 2019

I am sorry, but the last change does not make sense at all. Why use the general tag div and add an attribute role, since there is a nav tag.
Please restore the nav tag. I won't argue about the role attribute, although I don't agree with Brian.

avatar chmst
chmst - comment - 27 Jan 2019

I see the problem with IE11. So w coud do it this way and use a role="navigation" with aria-label.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.
avatar zwiastunsw
zwiastunsw - comment - 27 Jan 2019

Use <nav role="navigation" ... as Brian writes

avatar zwiastunsw
zwiastunsw - comment - 27 Jan 2019

I have tested this item ? unsuccessfully on 8c30cef

Use <nav role="navigation" ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.

avatar zwiastunsw zwiastunsw - test_item - 27 Jan 2019 - Tested unsuccessfully
avatar wojsmol
wojsmol - comment - 28 Jan 2019

I have tested this item successfully on c84724a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.

avatar wojsmol wojsmol - test_item - 28 Jan 2019 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 28 Jan 2019

I have tested this item successfully on c84724a

I have tested successfully, but I still think that the role attribute is redundant. Please settle the dispute @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.

avatar zwiastunsw zwiastunsw - test_item - 28 Jan 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jan 2019

I have tested this item successfully on c84724a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23685.

avatar brianteeman brianteeman - test_item - 28 Jan 2019 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 28 Jan 2019

nav_element

avatar brianteeman
brianteeman - comment - 28 Jan 2019

That shows html validation and as already explained several times now Internet explorer does not map nav to the accessibility api. There is nothing to resolve. You are simply wrong.

https://mobile.twitter.com/brianteeman/status/1089555677780082690?s=19

avatar zwiastunsw
zwiastunsw - comment - 28 Jan 2019

As I wrote earlier. The role attribute is redundant in this case. Tag without attribute is fully correct. I understand that you want to ensure better accessibility for IE11 users as well.
I take note of this. But that doesn't mean I'm wrong. I have already presented arguments. Joomla4 will be used for the next few years.
I understand that consistently, in all cases of new HTML5 tags, we will add a redundant role attribute, e.g. in a Cassiopeia template.

avatar brianteeman
brianteeman - comment - 28 Jan 2019

Joomla supports ie11 therefore it must have the role and therefore it is not redundant

avatar wilsonge wilsonge - change - 27 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-27 14:44:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Feb 2019
avatar wilsonge wilsonge - merge - 27 Feb 2019
avatar wilsonge
wilsonge - comment - 27 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment