User tests: Successful: Unsuccessful:
Add a landmark NAV to bredcrumbs module to improve navigation
View sourcecode before and after patch.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
I have tested this item
@zero-24 @SniperSister rips please
Rebooted drone @ http://ci.joomla.org/joomla/joomla-cms/13960
Rips and drone are happy now.
Sorry this is not correct. As we still support IE 11 it is required to also have role=navigation
See https://www.drupal.org/project/drupal/issues/2655764#comment-11322013
and https://www.html5accessibility.com/#support
I tested in Windows 10 and Internet Explorer 11 with NVDA. IE11 supports tag nav
. Screen reader announces a landmark.
I asked https://caniuse.com/#search=nav
It seems that all modern browsers support the nav tag.
caniuse doesnt cover the accessibility tree ;)
according to all the docs i can find online ie11 doesnt support it. Although I can confirm Stefan results
My proposal:
Labels |
Added:
?
|
I am sorry, but the last change does not make sense at all. Why use the general tag div
and add an attribute role
, since there is a nav
tag.
Please restore the nav
tag. I won't argue about the role attribute, although I don't agree with Brian.
I see the problem with IE11. So w coud do it this way and use a role="navigation" with aria-label.
Use <nav role="navigation" ...
as Brian writes
I have tested this item
Use <nav role="navigation" ...
I have tested this item
I have tested this item
I have tested successfully, but I still think that the role attribute is redundant. Please settle the dispute @wilsonge
I have tested this item
That shows html validation and as already explained several times now Internet explorer does not map nav to the accessibility api. There is nothing to resolve. You are simply wrong.
https://mobile.twitter.com/brianteeman/status/1089555677780082690?s=19
As I wrote earlier. The role attribute is redundant in this case. Tag without attribute is fully correct. I understand that you want to ensure better accessibility for IE11 users as well.
I take note of this. But that doesn't mean I'm wrong. I have already presented arguments. Joomla4 will be used for the next few years.
I understand that consistently, in all cases of new HTML5 tags, we will add a redundant role attribute, e.g. in a Cassiopeia template.
Joomla supports ie11 therefore it must have the role and therefore it is not redundant
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-27 14:44:51 |
Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on bcaab10