? ? Pending

User tests: Successful: Unsuccessful:

avatar amitranjan2
amitranjan2
26 Jan 2019

Pull Request for Issue #23677

Summary of Changes

Added
use Joomla\CMS\Language\Text;
use Joomla\CMS\Factory;
use Joomla\CMS\Router\Route;
use Joomla\CMS\Layout\LayoutHelper;

and changed JText to Text
similary to JFactory ,JRoute,JLayoutHelper

Testing Instructions

Components >> smart search >> Search Filters >>New
then write title name and click >> save and close

Expected result

It should be saved and title name should be displaced

Actual result

0 Class 'Text' not found

Documentation Changes Required

NO

avatar amitranjan2 amitranjan2 - open - 26 Jan 2019
avatar amitranjan2 amitranjan2 - change - 26 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2019
Category Administration com_finder
avatar amitranjan2 amitranjan2 - change - 26 Jan 2019
Labels Added: ?
5517fa5 26 Jan 2019 avatar amitranjan2 fix
c5ee1db 26 Jan 2019 avatar amitranjan2 fix
6be7785 26 Jan 2019 avatar amitranjan2 fix
avatar amitranjan2
amitranjan2 - comment - 30 Jan 2019

@Quy I think it's fine now, please review this

avatar Anu1601CS
Anu1601CS - comment - 8 Feb 2019

I have tested this item successfully on f00491a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23679.

avatar Anu1601CS Anu1601CS - test_item - 8 Feb 2019 - Tested successfully
avatar amitranjan2
amitranjan2 - comment - 12 Feb 2019

@Quy could you please test this PR ?

avatar Quy Quy - change - 13 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23679.

avatar infograf768 infograf768 - change - 13 Feb 2019
Labels Added: ?
avatar amitranjan2
amitranjan2 - comment - 2 Mar 2019

@wilsonge if no issue , please merge this

avatar HLeithner HLeithner - close - 2 Mar 2019
avatar HLeithner HLeithner - merge - 2 Mar 2019
avatar HLeithner HLeithner - change - 2 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-02 14:28:22
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 2 Mar 2019

thx

avatar amitranjan2
amitranjan2 - comment - 2 Mar 2019

thanks

Add a Comment

Login with GitHub to post a comment