[#23672] - [4.0] Inconsistent module header text
- Fixed in Code Base
- 13 Jul 2019
- Medium
- Build: 4.0-dev
- # 23672
- Diff
- brianteeman:mod_logged
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
All the other modules in the admin control panel use Date. The Loggedin module was using Last activity.
This simple PR changes the text to make it consistent
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Not sure if that makes sense. "Last Activity" doesn't mean it's the date the user logged in, it's the last time he performed an action.
Are you sure? My test shows that it is the Date of the log in. Which is the same as shown in the USer list as the "last visit date"
It's an assumption based on the text and that the date is taken from the session "time" column. I think the session timer is "reset" each time you perform an action.
But I don't know for sure. Someone who knows better how the session works could probably say more.
If it's indeed the logged-in date, I would actually just remove that string and use JDATE instead.
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings | ⇒ | Administration Language & Strings Modules |
Updated to use JDATE
| Category | Administration Language & Strings Modules | ⇒ | Administration Modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23672.
Question.... in changing it to Date is that not a false statement given it's Date / Time ? Should it be:
Date / Time ?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23672.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-13 19:15:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
| Category | Administration Modules | ⇒ | Administration Language & Strings Modules |
So it's the time of the session creation OR if someone formally closes the session it gets updated by the handler's write method
Thanks!
Thanks
Not sure if that makes sense. "Last Activity" doesn't mean it's the date the user logged in, it's the last time he performed an action.
If you only name it "Date", then I'd assume the column says when he logged in. Since the module is named "Logged-in Users".
For the "Recently Added Articles", the date correlates with the title as it tells when the articles was added, not eg when the latest edit occured.