Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23669] - [4.0] FIX SQL int default value to numeric

? ? Pending

User tests: Successful: Unsuccessful:

avatar amitranjan2
amitranjan2
25 Jan 2019

Pull Request for Issue #23668

Summary of Changes

INT DEFAULT value changed to numeric from char

Steps to reproduce the issue

joomla-cms/administrator/components/com_finder/sql/install.mysql.sql

Line 77

hits INT(11) NOT NULL DEFAULT '1',

Expected result

same as before

Actual result

same as before

Documentation Changes Required

NO

avatar amitranjan2 amitranjan2 - open - 25 Jan 2019
avatar amitranjan2 amitranjan2 - change - 25 Jan 2019
Status New ⇒ Pending
avatar amitranjan2 amitranjan2 - change - 25 Jan 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2019
Category ⇒ Administration com_finder Repository SQL Installation
a803095 26 Jan 2019 avatar amitranjan2 sql
6de42a7 26 Jan 2019 avatar amitranjan2 sql
avatar amitranjan2 amitranjan2 - change - 27 Jan 2019
The description was changed
avatar amitranjan2 amitranjan2 - edited - 27 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2019
Category Administration com_finder Repository SQL Installation ⇒ Administration com_finder SQL Installation
avatar alikon
alikon - comment - 27 Jan 2019

don't forget to take care of postgresql too
for example https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/sql/postgresql/joomla.sql#L757

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2019
Category Administration com_finder SQL Installation ⇒ Administration com_finder SQL Installation Postgresql
avatar amitranjan2
amitranjan2 - comment - 27 Jan 2019

Done

5f755f2 27 Jan 2019 avatar amitranjan2 fix
31da6c6 27 Jan 2019 avatar amitranjan2 fix
avatar amitranjan2
amitranjan2 - comment - 28 Jan 2019

@alikon I think it's fine now, please review this

avatar alikon
alikon - comment - 28 Jan 2019

I have tested this item ✅ successfully on d69fbae

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23669.

avatar alikon alikon - test_item - 28 Jan 2019 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 31 Jan 2019

I have tested this item ✅ successfully on 15d77e6

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23669.

avatar Anu1601CS
Anu1601CS - comment - 31 Jan 2019

I have tested this item ✅ successfully on 15d77e6

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23669.

avatar Anu1601CS Anu1601CS - test_item - 31 Jan 2019 - Tested successfully
avatar Quy Quy - change - 31 Jan 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 31 Jan 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23669.

avatar Quy
Quy - comment - 31 Jan 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23669.

avatar amitranjan2 amitranjan2 - change - 1 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - close - 4 Feb 2019
avatar wilsonge wilsonge - merge - 4 Feb 2019
avatar wilsonge wilsonge - change - 4 Feb 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-02-04 23:48:15
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 4 Feb 2019

Thankyou very much for your first contribution! Much appreciated!

avatar amitranjan2
amitranjan2 - comment - 5 Feb 2019

Thanks a lot

Add a Comment

Login with GitHub to post a comment