Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23667] - [4.0] FIX Unreliable way of loading ServiceProviderInterface class in ExtensionManagerTrait.php

? Pending

User tests: Successful: Unsuccessful:

avatar joeforjoomla
joeforjoomla
25 Jan 2019

Pull Request for Issue #22825 .

Summary of Changes

Use the Factory to cache loaded extensions throughout different Application instances

Testing Instructions

See previous PR #22825

Expected result

Loaded extensions from the cache are always correct

Actual result

Loaded extensions from the cache are always correct

avatar joeforjoomla joeforjoomla - open - 25 Jan 2019
avatar joeforjoomla joeforjoomla - change - 25 Jan 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2019
Category ⇒ Libraries
avatar laoneo
laoneo - comment - 27 Jan 2019

If you want to make a cache, then better to use the ExtensionHelper class inszead of the already polluted Factory.

avatar joeforjoomla joeforjoomla - change - 29 Jan 2019
Labels Added: ?
avatar joeforjoomla
joeforjoomla - comment - 29 Jan 2019

I agree @laoneo this PR has been modified to properly implement an extensions cache using the ExtensionHelper class.
Please test.

avatar joeforjoomla
joeforjoomla - comment - 11 Mar 2019

Can this PR be tested and merged ASAP? Otherwise it's difficult to fully test extensions everytime that a new alpha version is released. Pinging @wilsonge here, thanks George!

avatar wilsonge
wilsonge - comment - 15 Mar 2019

Thanks for the ping - sorry I missed this - LGTM!

avatar wilsonge wilsonge - change - 15 Mar 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-03-15 11:10:05
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 15 Mar 2019
avatar wilsonge wilsonge - merge - 15 Mar 2019
avatar joeforjoomla
joeforjoomla - comment - 15 Mar 2019

Thanks @wilsonge ! You are the best :)

Add a Comment

Login with GitHub to post a comment