[#23665] - [4.0] Toolbar to use Custom Element dropdowns
- Closed
- 24 Apr 2019
- Medium
- Build: 4.0-dev
- # 23665
- Diff
- C-Lodder:dropdowns
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR utilises the dropdowns Custom Element.
It still requires some JS refactoring and support for RTL, however that can be done in the CE repo at a later date
Requires joomla-projects/custom-elements#111 to be merged
To-do
- Properly import the dropdown custom element when using
npm i
Result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Layout Libraries |
| Labels |
Added:
?
|
||
@infograf768 RTL support added
FWIW the code for the Dropdown Element is utterly crap (talking for my own code here, not the changes Charlie did) in the other repo BUT the only attribute that will remain also in the upcoming Custom Element is for. So I guess this is ok-ish.
Although I will recommend to simply copy the CE in the main repo for the time being and remove it when the new one is available in the other repo...
@dgrammatiko sure, I'll copy the CSS/JS over so it can at least be tested. Please note the wrapper I've used though. Not ideal but actually essential
@dgrammatiko I will do that as a separate PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-24 08:57:15 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Removed:
J4 Issue
|
||
Rant:: RTL is almost always forgotten until last minute (if it is). It should always be dealt with for any PR imho, and not "later". Nothing personal. Just a general rant.