[#23644] - [4.0] Copy icon in debug bar doesn't show
- Closed
- 1 Feb 2019
- Medium
- Build: staging
- # 23644
Steps to reproduce the issue
- Go to Global Configuration
- Enable the Debug System
- Go to System
- Click on Plugins
- Search on
debug - Make sure the
System - Debugplugin is enabled
When you see the debug bar click on the Queries word and the debug bar will open and show the queries. There is a Copy function with an icon but the icons doesn't show. Same goes for other icons in that list:
Expected result
The correct icons are shown
Actual result
The incorrect icon is shown
System information (as much as possible)
Joomla 4.0-dev #d0c00c50822d69730d2b1c4ee6e4315bf8adc0b5
Firefox/Safari
PHP 7.2.14
joomla-cms-bot
- | Labels |
Added:
?
|
||
@infograf768 which file should I approach to solve this issue?
The error looks related to the use of
font-family: PhpDebugbarFontAwesome;
instead of FontAwesome
There is a specific definition for PhpDebugbarFontAwesome in
/media/vendor/debugbar/vendor/font-awesome/css/font-awesome.min.css
(after using npm ci)
It looks like the file is not loaded.
@infograf768 I've changed the font-family from PhpDebugbarFontAwesome to FontAwesome in build/media/plg_system_debug/widgets/languageStrings/widget.css and build/media/plg_system_debug/widgets/sqlqueries/widget.css but it doesn't work for me.
@hardik-codes
I am afraid that would not work as we need to load
/media/vendor/debugbar/vendor/font-awesome/css/font-awesome.min.css
which has specific css for the debug, not only for sqlqueries.
@elkuku please look into this.
@hardik-codes
Indeed changing the font name in the widget.css in the build folder solves the issue BUT one has to run npm ci to get the right code in the minified widget.min.css in the media folder as it is always the minified file which is loaded, even when debug is on.
Contrary to what I thought first, /media/vendor/debugbar/vendor/font-awesome/css/font-awesome.min.css is useless...
Which means that /libraries/vendor/maximebf/debugbar/src/DebugBar/JavascriptRenderer.php is not used.
making patch now.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-01 07:15:27 |
| Closed_By | ⇒ | infograf768 |
Confirmed, since the implementation of new debug.