Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#2364] - Improving code quality for mod_search

? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
29 Oct 2013

This PR started to take care of the blue No values in the search module options. I added some other code improvements to it:

  • button and imagebutton parameter now use 0 and 1 as possible values instead of null (not set) and 1.
  • button and imagebutton parameter now consistently default to 0 in XML and code.
  • button_pos parameter now consistently defaults to left in XML and code.
  • set_itemid parameter now uses the menuitem fieldtype. This allows users to select a menu item from the list instead of entering the number manually.
  • Improved layout code, moved the switch statement into the if clause since it's only needed if a button is shown.

This should change nothing for existing sites.

Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32456

avatar Bakual Bakual - open - 29 Oct 2013
avatar Bakual
Bakual - comment - 9 Nov 2013

Updated to master and included suggestions from @infograf768

avatar mbabker mbabker - reference | - 10 Nov 13
avatar mbabker mbabker - close - 10 Nov 2013
avatar Bakual Bakual - head_ref_deleted - 10 Nov 2013
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment