[#23637] - [4.0] Fix debug
- Fixed in Code Base
- 5 Mar 2019
- Medium
- Build: 4.0-dev
- # 23637
- Diff
- dgrammatiko:4.0-devfix-debug
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
DebugBar is always placing assets in the head. Now it doesn't.
This is a temporary solution till somebody fix this in a proper way: eg assets should always use the Joomla API!!
Testing Instructions
Enable debug and check the admin login page
Expected result
Actual result
Documentation Changes Required
There are a few todo's here that need to be addressed: #23598 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
Before the test the debug bar did not show up and the console was filled with JavaScript errors. After applying the patch, the JavaScript errors are gone and the debug bar displays.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23637.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23637.
Restarted drone
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23637.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23637.
@SniperSister can you have a look here?
Fixed!
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-05 10:51:31 |
| Closed_By | ⇒ | wilsonge |
I think I'll take another pass at this at some point and try and fix this to go through the Joomla API. But will do for now. Thanks!
I have tested this item✅ successfully on 9975a0c
Before the test the debug bar did not show up and the console was filled with JavaScript errors. After applying the patch, the JavaScript errors are gone and the debug bar displays.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23637.