?
avatar C-Lodder
C-Lodder
22 Jan 2019

Steps to reproduce the issue

Attempt to install multilingual sample data without having installed any additional languages

Expected result

Grey out the "Install" button if the criteria hasn't been met

Actual result

Required to click "Install", then confirm an alert message, then a danger alert is displayed

screenshot_2019-01-22 control panel - joomla 4 - administration

avatar C-Lodder C-Lodder - open - 22 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Jan 2019
avatar Bakual
Bakual - comment - 22 Jan 2019

See #20749 for a change in that behavior, which would completely hide the option if the criteria is not met.
You suggestions would be an alternative, but would require an API change in how the module works.

avatar C-Lodder
C-Lodder - comment - 22 Jan 2019

@Bakual Hiding the option probably isn't a good idea as users could be wondering how to install sample data. Greying out the button would be much more appropriate.

avatar Bakual
Bakual - comment - 22 Jan 2019

I'm no fan of either actually.

The text already states what the requirements are, and when you press the button it clearly says what you're missing. That's fine for me.
If we grey out the button, you would also have to dynamically tell the user somehow what exactly he is missing. Maybe by clicking the button you'd get a help text or whatever. In the end, you just complicate the code but don't gain anything. But that's a personal opinion.

avatar infograf768
infograf768 - comment - 22 Jan 2019

I think this alert is fine. Obsfuscating the possibility would make it a hidden feature, as well as multilang in general by the way.

avatar Quy
Quy - comment - 22 Jan 2019

Duplicate #23028?

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-03-04 08:51:09
Closed_By joomla-cms-bot
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2019
Status Closed Duplicate Report
Closed_By joomla-cms-bot franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - close - 4 Mar 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Mar 2019

Duplicate of #23028

Add a Comment

Login with GitHub to post a comment