?
avatar C-Lodder
C-Lodder
22 Jan 2019

Steps to reproduce the issue

Install some sample data via the Control Panel

Expected result

Green alerts

Actual result

Blue alerts

screenshot_2019-01-22 control panel - joomla 4 - administration

avatar C-Lodder C-Lodder - open - 22 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Jan 2019
avatar Bakual
Bakual - comment - 22 Jan 2019

I think the class is defined here: https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_src/mod_sampledata/js/sampledata-process.es6.js#L62
The rest is CSS.

Is it the wrong class or is the CSS wrong?

avatar C-Lodder
C-Lodder - comment - 22 Jan 2019

It's not the CSS that's wrong, it's the type attribute:

<joomla-alert type="info"></joomla-alert>

The type should be success, not info

avatar Bakual
Bakual - comment - 22 Jan 2019

Ah, then I'm out as I don't know where that comes from. Must be somewhere in the JS stuff.

avatar infograf768
infograf768 - comment - 23 Jan 2019

Also 'success' or 'error' should be translated in the message.

avatar hardik-codes
hardik-codes - comment - 25 Jan 2019

@C-Lodder changing the type attribute from info to success in https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/stats/layouts/message.php does not work out in my local machine. Are there any more changes to be done apart from the one above ??

avatar C-Lodder
C-Lodder - comment - 25 Jan 2019

You'll most likely need to change the JS

avatar hardik-codes
hardik-codes - comment - 25 Jan 2019

JS in which file?

avatar Bakual
Bakual - comment - 25 Jan 2019

The JS file involved is https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_src/mod_sampledata/js/sampledata-process.es6.js
After any modification you need to run the npm commands to compile that thing. Don't ask me details ?

avatar hardik-codes
hardik-codes - comment - 25 Jan 2019

How do I check whether my changes are implemented or not because the Sample data installation process is a single time process and cannot be reverted back??

avatar Bakual
Bakual - comment - 25 Jan 2019

You can install it as many times as you want. But you need to delete the created categories and items so you don't get an error (because the item already exists).
It also works if you have a backup of the original database that you can restore.

avatar hardik-codes
hardik-codes - comment - 29 Jan 2019

@Bakual I deleted all the created categories but it is still giving me the error on install. What's the other way round

avatar Bakual
Bakual - comment - 29 Jan 2019

Either manually delete all created items (categories, articles, menuitems, ...), use a database backup of a previous state or drop the database tables and do a fresh installation. That's about the variants.

avatar infograf768
infograf768 - comment - 31 Jan 2019

Delete in this order:
First: Menus (that will also delete the menu items). Do not delete the default mainmenu.
Second: Articles
Third: Categories

avatar infograf768
infograf768 - comment - 31 Jan 2019

https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_src/mod_sampledata/js/sampledata-process.es6.js#L62 imho concerns the progress bar and not the body of the message.

avatar infograf768
infograf768 - comment - 31 Jan 2019

Ok, I have a patch for that. Creating PR now.

avatar hardik-codes
hardik-codes - comment - 31 Jan 2019

Patch for which issue? @infograf768

avatar infograf768
infograf768 - comment - 31 Jan 2019

the colour for the background of the messages should be greenish instead of blue. The issue stated by the OP.
I.e. to obtain
screen shot 2019-01-31 at 11 20 06

PR ready in a few minutes.

avatar hardik-codes
hardik-codes - comment - 31 Jan 2019

May I help with that ?
Please suggest me the changes I'll more than willing to generate the PR asap.

avatar infograf768
infograf768 - comment - 31 Jan 2019

Already done. Please test #23726
Closing as we have a patch

avatar infograf768 infograf768 - change - 31 Jan 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-01-31 10:34:08
Closed_By infograf768
avatar infograf768 infograf768 - close - 31 Jan 2019

Add a Comment

Login with GitHub to post a comment