J4 Issue ?
avatar C-Lodder
C-Lodder
22 Jan 2019

Steps to reproduce the issue

Go to create a new article, menu item, etc..
You'll notice that the "Title" input is the same length as the "Alias" input below.

Expected result

The "Title" input should be longer which it used to be in an earlier state of J4

Actual result

Same length

avatar C-Lodder C-Lodder - open - 22 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Jan 2019
avatar dgrammatiko
dgrammatiko - comment - 23 Jan 2019

Fields should always have a 100% width setting width in 240px or whatever is not very responsive and also is a huge anti pattern. Mobile first...
Also the div soup around the label and the input is totally crap and needs to go...

avatar infograf768
infograf768 - comment - 25 Jan 2019

+1

avatar hardik-codes
hardik-codes - comment - 25 Jan 2019

Does this issue needs to be addressed @dgrammatiko and @infograf768

avatar dgrammatiko
dgrammatiko - comment - 25 Jan 2019

The "Title" input should be longer which it used to be in an earlier state of J4

Why the distinction? For what is worth all inputs should have a width 100% and the container div will act as the upper hard limit...

avatar C-Lodder
C-Lodder - comment - 25 Jan 2019

@dgrammatiko I believe it was requested by some users as it was a more meaningful field.

avatar hardik-codes
hardik-codes - comment - 28 Jan 2019

@C-Lodder does this issue needs to be taken forward ?

avatar C-Lodder
C-Lodder - comment - 29 Jan 2019

Not sure really. Im just basing this on J3 and an earlier state of J4.

@coolcat-creations will be able to give her feedback

avatar hardik-codes
hardik-codes - comment - 29 Jan 2019

@C-Lodder how do I contact @coolcat-creations regarding this?

avatar C-Lodder
C-Lodder - comment - 29 Jan 2019

She'll get a notification with the above tags

avatar coolcat-creations
coolcat-creations - comment - 1 Feb 2019

I agree to @dgrammatiko - about the length. Thanks for following up. Can anyone take care of this issue?

avatar hardik-codes
hardik-codes - comment - 1 Feb 2019

Yes I'm in @coolcat-creations . Please specify what exactly are the changes to be made

avatar infograf768
infograf768 - comment - 5 Feb 2019

There are 2 places to look at:
For the extra div
/layouts/joomla/edit/title_alias.php

I just modified it here to

<?php
/**
 * @package     Joomla.Site
 * @subpackage  Layout
 *
 * @copyright   Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

defined('JPATH_BASE') or die;

$form  = $displayData->getForm();

$title = $form->getField('title') ? 'title' : ($form->getField('name') ? 'name' : '');

echo $title ? $form->renderField($title) : '';
echo $form->renderField('alias');

for the css:
changes to be done in /administrator/templates/atum/scss/blocks/_form.scss

.form-control {
  max-width: $input-max-width;
  background-color: var(--white-offset);
}

This css override default bootstrap 100% for this class.
Not sure if we should delete the max-width or set it to 100% or none.
All depends on what we do finally about bootstrap...

avatar infograf768
infograf768 - comment - 7 Feb 2019

@coolcat-creations
What do you think?

avatar hardik-codes
hardik-codes - comment - 14 Feb 2019

On changing the max-width: $input-max-width; the width of both title filed and alias field change simultaneously.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2019
Status New Information Required
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Mar 2019

Reminder at @coolcat-creations for above Comment by @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23626.

avatar coolcat-creations
coolcat-creations - comment - 6 Mar 2019

Please see this screen: https://coolcat-creations.com/joomla/#/screens/267320995
But take Dimitris suggestion into account that both fields have 50% in Desktop and 100% width in Mobile.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Mar 2019
Status Information Required Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Category Templates (admin)
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar C-Lodder C-Lodder - change - 10 Apr 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-04-10 07:43:37
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 10 Apr 2019

Add a Comment

Login with GitHub to post a comment