[#23618] - Protostar - please add Google font for body setting to template style manager
- Closed
- 21 May 2019
- Medium
- Build: 3.9.2
- # 23618
The style manager for the Protostar template allows for setting "Google font for headings", which I find very convenient. But I also need to be able to set Google font for body of articles in a corresponding fashion, a feature that in my opinion is a logical compliment to the former. In other words,
"Google font for headings" allows setting font for h1, h2, h3, h4, h5, h6 and .site-title, afaik.
I would need something analogous for setting font for body.
Can you please add it as well?
Thank you.
| Status | New | ⇒ | Information Required |
What kind of comment? @franz-wohlkoenig ? :D
If this is something to discuss or close.
it's about having the correct Solution and also a Volunteer having Time and Interest to do a Pull Request, having two successfully Tests, ...
Although it is pretty easy to implement (patch would take a few minutes only, and not exactly as described in that link which dates back from 2014), it depends on the decision of @HLeithner as this can be done as a simple change in a copy of protostar.
Theres also the Opinion to do new Features only against J4.
I would not consider this as a real new feature as it concerns only Protostar which is not used in 4.0 ;)
Technically it's still a new feature
Not wrong.
| Status | Information Required | ⇒ | Discussion |
@HLeithner Release Lead decide :-)
Is this really useful? Doesn't a custom.css does the same in 3 lines?
But I will merge it if its only a small addition because it doesn't effect merging into 4.0 (because it doesn't exists in j4)
You have to find someone that could write a PR
| Labels |
Added:
J3 Issue
|
||
| Closed_By | alikon | ⇒ | joomla-cms-bot |
| Labels | |||
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-21 10:10:05 |
| Closed_By | ⇒ | alikon | |
| Labels | |||
Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/23618
closing as it is a new feature on protostar and new feature must go on 4.x and 4.x don't have protostar
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23618.
@zero-24 can you please comment?