[#23616] - Http: Fix Curl transport's POSTFIELDS encoding.
- Closed
- 4 Apr 2022
- Medium
- Build: staging
- # 23616
- Diff
- coling:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
When the POST fields are supplied as an array but the PHP arg_separator.input
configuration option is not set to & (e.g. if it's set to &) then this
will result in malformed post requests.
This is easily seen in e.g. reCaptcha verification requests.
Summary of Changes
Changed the call to http_build_query() to be explicit about the separator argument to use when constructing the query string.
Testing Instructions
Run Joomla in an environment with arg_separator.input set to '&' and then try and submit a contact request with a reCaptcha configured.
Expected result
The contact form would be submitted and sent.
Actual result
An error is reported "missing-input-reponse" and "Missing field: Captcha"
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-04 13:02:36 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
Removed: ? |
||
Sorry that it took so long to respond. As this is a nice change, would be good to change all
http_build_querycalls in the whole code base. It would be good to have that change in Joomla 4 rather 3. Can you rebase the pr onto the branch 4.2-dev. In the meantime, I'm closing this pr, when ready, please reopen again. Thanks for your help making Joomla better.