[#23613] - [4.0] Remove the 1.5 "oldstatic" Cachemethod
- Fixed in Code Base
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 23613
- Diff
- Bakual:RemoveOldstatic
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removes the oldstatic cachemethod. According to the comment this was the Joomla 1.5 cache style which was only kept for B/C reasons.
I've changed the default cachemethod to static
Testing Instructions
I don't think this can actually be tested since no core module is using that method. I don't even know if that method actually works.
It's more code review and the decision if we want to keep that legacy cache behavior.
Documentation Changes Required
Don't know.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Since it's not an own function, it can't be properly deprecated.
We could add a log message in case that cachemethod is used.
If required, I can do that PR for the 3.10 branch.
I have tested this item
on review
p.s
for the #deprecated# issue not sure if we need to still take care of 1.5 cache style
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23613.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23613.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 17:44:05 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: J4 Issue |
||
Thanks!
Shouldnt it be marked as deprecated in j3 before it can be removed in j4