? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
20 Jan 2019

Pull Request for Issue #23465 .

Summary of Changes

Enable changing the default workflow again.

Testing Instructions

See the issue for testing instructions.

avatar bembelimen bembelimen - open - 20 Jan 2019
avatar bembelimen bembelimen - change - 20 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jan 2019
Category Administration com_workflow
avatar bembelimen bembelimen - change - 20 Jan 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 26 Jan 2019

You can now switch the default by clicking on the icon - so that is correct
BUT as a consequence I see that the "Joomla Default" workflow now appears to be editable although it is not - I agree it should not be editable but then the pencil icon should not be displayed

chrome_2019-01-26_14-13-21

avatar bembelimen
bembelimen - comment - 2 Feb 2019

Thanks @brianteeman fixed it.

avatar brianteeman
brianteeman - comment - 3 Feb 2019

I can confirm the pencil issue is now resolved.

But I now notice that you cannot unpublish that workflow even if it no longer the default. Is that intended?

avatar bembelimen
bembelimen - comment - 3 Feb 2019

But I now notice that you cannot unpublish that workflow even if it no longer the default. Is that intended?

From my side it was intended, yes, but I have no feelings about it...it was a wish to have the default workflow unchangeable...

avatar brianteeman
brianteeman - comment - 3 Feb 2019

OK I will mark it as a successful test then

avatar brianteeman
brianteeman - comment - 3 Feb 2019

I have tested this item successfully on e7602ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23607.

avatar brianteeman brianteeman - test_item - 3 Feb 2019 - Tested successfully
avatar chmst
chmst - comment - 3 Feb 2019

I have tested this item successfully on e7602ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23607.

avatar chmst chmst - test_item - 3 Feb 2019 - Tested successfully
avatar Quy Quy - change - 3 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23607.

avatar wilsonge wilsonge - change - 5 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-05 22:05:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Feb 2019
avatar wilsonge wilsonge - merge - 5 Feb 2019
avatar wilsonge
wilsonge - comment - 5 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment