[#23597] - [4.0] Installation from the source fix
- Fixed in Code Base
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 23597
- Diff
- twister65:4.0-install
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23592 .
Summary of Changes
-
Use "1.1.4" version for the awesomplete package.
-
Add git instruction to the installation process.
Testing Instructions
-
Clone the repository:
git clone git@github.com:joomla/joomla-cms.git -
Go to the joomla-cms folder:
cd joomla-cms -
Checkout 4.0-dev branch:
git checkout 4.0-dev -
Install all the needed composer packages:
composer install -
Install all the needed npm packages:
npm install
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Title |
|
||||||
@brianteeman there was some bug in the latest (old) npm release thus the change to the GitHub repo. But yeah if there is a fairly recent release we should go back to npm
Edit: that last release was 2 weeks ago, so yes we need o switch to NPM here
https://www.npmjs.com/package/awesomplete last updated 13 days ago
| Labels |
Added:
?
|
||
Could we delete package-lock.json file ?
delete it then run npm install and will be regenerated. You have to do this and commit the new file..
package-lock.json is generated during the installation.
It is automatically deleted when npm install is finished.
I think, we don't need it.
Sorry, the lock file cannot be removed, please restore it after updating it
Why ?
It is there for integrity, you cannot remove it: read about it here: https://docs.npmjs.com/files/package-lock.json
The problem is that I do not have package-lock.json file in my joomla-cms folder, because npm install succeeded.
I can not invent it !
npm install automatically generates this file so there should be there
No
What Node/NPM versions are you using? That lock file should be there after installing or updating a package. As pointed out, deleting it is not a good idea because that will cause contributors to have different versions of transient dependencies (same as if the Composer lock file were removed).
I am using:
2 info using npm@3.5.2
3 info using node@v8.10.0
You need to update Node and NPM. The engines node in package.json lists minimum required versions of Node and NPM, the versions you posted are below that.
In you terminal run sudo npm install -g npm. Your npm is outdated
⇒ npm -v
6.5.0
Updated, thanks.
What is the failure of the drone?
Nobody needs to install Joomla from scratch ? Nobody to test that ? Surprising...
Fix the conflicts here and lets' get this in
| Labels |
Removed:
J4 Issue
|
||
| Category | Repository | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 16:16:41 |
| Closed_By | ⇒ | wilsonge |
Thanks!
wouldnt it be better to use the npm package?