[#23569] - [staging] Contact Banned parameters work only from component Options
- Closed
- 18 Jan 2019
- Medium
- Build: staging
- # 23569
- Diff
- infograf768:contact_banned
User tests: Successful: Unsuccessful:
Pull Request for Issue #23546
Summary of Changes
Concerns Banned Email, Banned Subject, Banned Text parameter fields.
The validation of these, before this patch, is only done depending on the parameters defined in the component Options Form tab.
Whatever has been entered in the Contact menu item or in the Contact itself are ignored.
Testing Instructions
Tests have to be done when one sends mail to a contact in frontend.
The priorities for these parameters depend if the contact is displayed from a single contact menu item or not.
Set the parameters in the various places below and test priorities. Creating the params and taking them off between each test.
Case1: From a single contact menu item
Priority1: menu item parameters
Priority2: Contact parameters
Priority3: Component parameters
Case2: No single contact menu item
For example for another type of contacts menu item or from no menu item at all when clicking on the author link in an article.
Priority1: Contact parameters
Priority2: Component parameters
Test is successful when one gets a message of the type depending on the field where the banned item is used.
Error:
Invalid field: Email
Invalid field: Subject
Invalid field: Message
Before patch
Only the Component parameters are used.
After patch
Parameters used depend on the priorities.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23569.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23569.
To tell the truth, as these fields (as present for a contact or single contact menu item) never worked, even in 2.5 where we do have exactly the same code, another solution is to get rid of them and just keep the component Options ones.
It looks like this has not created issues for years and it did only when someone tried to use them.
@joomla/cms-maintainers @ChristineWk @viocassel
What do you think?
EDIT: This means deleting them in 6 .xml, 12 .sql, and some .csv and one .xml test files.
+1 for deleting
Delete them
@infograf768 Personally, I agree with you, but I do not know what other users or the thread creator means about it. Anyway Thanks for your investigation!
OK, will work on this and when ready will close this PR.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-18 16:41:55 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 80bfdde
Thank you @infograf768 - will inform forum accordingly
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23569.