[#23563] - Single contact - show contact name
- Fixed in Code Base
- 28 Feb 2019
- Medium
- Build: staging
- # 23563
- Diff
- brianteeman:contact_name
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"
It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information
This simple PR moves the field out of the contact information block and condition
Created this PR as it took me ages to find the option to remove the contact name from the page as the option was hidden ;)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Labels |
Added:
?
|
||
I have tested this item
I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J 3.9.2
contact info hide
contact info show
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I do not see any change in order of the options (Global configuration > Contacts) after applying this patch.
contact info hide
contact info show
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I do not see any change in order of the options (Global configuration > Contacts) after applying this patch.
contact info hide
contact info show
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
Hi,
tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
Hi,
tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
bugs and conflicts fixed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J3.9.3.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J3.9.3.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
It's not a matter of Global Configuration > Contacts.
The issue is about option on menu item on contacts/contact category/contact categories
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
Ok, I see now. What is the reason for
- leaving the other contact details (Contact's Position, Email, Street Address, City or Suburb, State or County, Postal/ZIP Code, Country, Telephone, Mobile Phone, Fax, Webpage, Image) - or at least dealing with bulks: Position, Email, Address, Phones, Webpage; or
- not changing the visible also in the Global configuration if
It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
I have tested this item
Ok, I see now. What is the reason for
- leaving the other contact details (Contact's Position, Email, Street Address, City or Suburb, State or County, Postal/ZIP Code, Country, Telephone, Mobile Phone, Fax, Webpage, Image) - or at least dealing with bulks: Position, Email, Address, Phones, Webpage; or
- not changing the visible also in the Global configuration if
It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-28 15:11:37 |
| Closed_By | ⇒ | HLeithner |
thx
thanks
I have tested this item✅ successfully on 85d4166
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.