? ?

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jan 2019

The option to display the contact name was inside the "contact information" options and was only visible to set if the "contact information" was set to "show"

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information

This simple PR moves the field out of the contact information block and condition

Created this PR as it took me ages to find the option to remove the contact name from the page as the option was hidden ;)

avatar brianteeman brianteeman - open - 16 Jan 2019
avatar brianteeman brianteeman - change - 16 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2019
Category Front End com_contact
avatar brianteeman brianteeman - change - 16 Jan 2019
Labels Added: ?
avatar viocassel
viocassel - comment - 27 Jan 2019

I have tested this item successfully on 85d4166


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar viocassel viocassel - test_item - 27 Jan 2019 - Tested successfully
avatar kofaysi
kofaysi - comment - 8 Feb 2019

I have tested this item 🔴 unsuccessfully on 85d4166

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J 3.9.2
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar kofaysi kofaysi - test_item - 8 Feb 2019 - Tested unsuccessfully
avatar kofaysi
kofaysi - comment - 8 Feb 2019

I do not see any change in order of the options (Global configuration > Contacts) after applying this patch.
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar kofaysi
kofaysi - comment - 8 Feb 2019

I do not see any change in order of the options (Global configuration > Contacts) after applying this patch.
contact info hide
contact info show


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar ladyjer ladyjer - test_item - 24 Feb 2019 - Tested unsuccessfully
avatar ladyjer
ladyjer - comment - 24 Feb 2019

I have tested this item 🔴 unsuccessfully on 85d4166

Hi,

tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar ladyjer
ladyjer - comment - 24 Feb 2019

Hi,

tested succesfully for category/tmp/default.xml and contact/tmp/deault.xml.
tested unsucessfully for categories/tmpl/default.xml. Order now is ok but still present "showon="show_info:1" for name field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar brianteeman
brianteeman - comment - 24 Feb 2019

bugs and conflicts fixed

avatar viocassel viocassel - test_item - 24 Feb 2019 - Tested successfully
avatar viocassel
viocassel - comment - 24 Feb 2019

I have tested this item successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar viocassel
viocassel - comment - 24 Feb 2019

I have tested this item successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar ladyjer ladyjer - test_item - 24 Feb 2019 - Tested successfully
avatar ladyjer
ladyjer - comment - 24 Feb 2019

I have tested this item successfully on 45cf4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar Quy Quy - change - 24 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar kofaysi kofaysi - test_item - 25 Feb 2019 - Tested unsuccessfully
avatar kofaysi
kofaysi - comment - 25 Feb 2019

I have tested this item 🔴 unsuccessfully on 45cf4e7

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J3.9.3.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar kofaysi
kofaysi - comment - 25 Feb 2019

I have tested this item 🔴 unsuccessfully on 45cf4e7

I do not see any change in option order (Global Configuration > Contacts) after applying the patch on J3.9.3.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar ladyjer
ladyjer - comment - 25 Feb 2019

It's not a matter of Global Configuration > Contacts.
The issue is about option on menu item on contacts/contact category/contact categories


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar kofaysi kofaysi - test_item - 25 Feb 2019 - Tested successfully
avatar kofaysi
kofaysi - comment - 25 Feb 2019

I have tested this item successfully on 45cf4e7

Ok, I see now. What is the reason for

  • leaving the other contact details (Contact's Position, Email, Street Address, City or Suburb, State or County, Postal/ZIP Code, Country, Telephone, Mobile Phone, Fax, Webpage, Image) - or at least dealing with bulks: Position, Email, Address, Phones, Webpage; or
  • not changing the visible also in the Global configuration if

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar kofaysi
kofaysi - comment - 25 Feb 2019

I have tested this item successfully on 45cf4e7

Ok, I see now. What is the reason for

  • leaving the other contact details (Contact's Position, Email, Street Address, City or Suburb, State or County, Postal/ZIP Code, Country, Telephone, Mobile Phone, Fax, Webpage, Image) - or at least dealing with bulks: Position, Email, Address, Phones, Webpage; or
  • not changing the visible also in the Global configuration if

It shouldn't be connected to the "contact information" as the display of the contact name is not conditional on the display of the contact information


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23563.

avatar infograf768 infograf768 - change - 26 Feb 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 28 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-28 15:11:37
Closed_By HLeithner
avatar HLeithner HLeithner - close - 28 Feb 2019
avatar HLeithner HLeithner - merge - 28 Feb 2019
avatar HLeithner
HLeithner - comment - 28 Feb 2019

thx

avatar brianteeman
brianteeman - comment - 28 Feb 2019

thanks

Add a Comment

Login with GitHub to post a comment