? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jan 2019

Expected

The module form should be wrapped in a div that a class suffix can be applied to

Actual

The module div is wrapped in the form tag

Changes

This simple PR switches the form and the div - making it the same structure as other modules - see mod_search - makes it easier (aka consistent) for styling and easier/cleaner when reading the outputted source code

avatar brianteeman brianteeman - open - 16 Jan 2019
avatar brianteeman brianteeman - change - 16 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2019
Category Modules Front End
avatar Quy
Quy - comment - 16 Jan 2019

I have tested this item successfully on 29c647e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23560.

avatar Quy
Quy - comment - 16 Jan 2019

I have tested this item successfully on 29c647e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23560.

avatar Quy Quy - test_item - 16 Jan 2019 - Tested successfully
avatar viocassel
viocassel - comment - 16 Jan 2019

I have tested this item successfully on 29c647e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23560.

avatar viocassel viocassel - test_item - 16 Jan 2019 - Tested successfully
avatar Quy Quy - change - 16 Jan 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23560.

avatar rdeutz rdeutz - change - 19 Jan 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-19 08:22:05
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Jan 2019
avatar rdeutz rdeutz - merge - 19 Jan 2019
avatar brianteeman
brianteeman - comment - 19 Jan 2019

Thanks

Add a Comment

Login with GitHub to post a comment